Skip to content
This repository was archived by the owner on Jul 1, 2025. It is now read-only.

Conversation

DimitriZhurkin
Copy link

@DimitriZhurkin DimitriZhurkin commented Oct 17, 2024

Committer Notes

Add the security-sensitivity-level-matches-security-impact-level constraint.

Note: Tested rigorously with various combinations of security-sensitivity-level and security-impact-level values.

All Submissions:

  • Have you selected the correct base branch per Contributing guidance?
  • Have you set "Allow edits and access to secrets by maintainers"?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated? Already addressed in automate.fedramp.gov docs, see help-url in constraint.
  • If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@DimitriZhurkin DimitriZhurkin requested a review from a team as a code owner October 17, 2024 14:27
wandmagic
wandmagic previously approved these changes Oct 17, 2024
Copy link

@wandmagic wandmagic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!
nice if / then usage

Gabeblis
Gabeblis previously approved these changes Oct 21, 2024
Copy link
Contributor

@Gabeblis Gabeblis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a non-blocking question about where this fits into the style guide.

@DimitriZhurkin DimitriZhurkin dismissed stale reviews from Gabeblis and wandmagic via cc82099 October 21, 2024 15:35
@DimitriZhurkin DimitriZhurkin requested a review from a team as a code owner October 21, 2024 15:35
aj-stein-gsa
aj-stein-gsa previously approved these changes Oct 21, 2024
Copy link

@Rene2mt Rene2mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks great. One blocking request to make minor update to the message.

Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I should learn to review my own notes and remember our previous conversations, happy to approve a second time with a now even more correct version. Thanks to all of you.

@aj-stein-gsa aj-stein-gsa requested a review from Rene2mt October 21, 2024 21:39
Copy link
Contributor

@Gabeblis Gabeblis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, we're just lacking proper documentation on this constraint.

Copy link
Contributor

@Gabeblis Gabeblis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work.

@aj-stein-gsa aj-stein-gsa merged commit 41d76e9 into GSA:develop Oct 24, 2024
5 checks passed
brian-ruf pushed a commit to brian-ruf/fedramp-automation that referenced this pull request Nov 8, 2024
* Add security-sensitivity-level-matches-security-impact-level

* Modify the message wording

* In the message, change MUST to SHOULD
This was referenced Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants