Add unit test metaschema conformant with ADR#6 #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are proposing changes to the structure of the JSON/YAML unit test file used for all constraints test suite management. This version documents the model of that YAML file before the proposed change in the comments of the GSA#817 PR, linked below. GSA#817 (comment)
aj-stein-gsa
added
the
type: backlog item
aj-stein-gsa
changed the title
This addresses changes that should be handled as determined by upstream guidance from metaschema-framework maintainers. metaschema-framework/metaschema-java#221 metaschema-framework/metaschema#44
aj-stein-gsa
force-pushed
the
chore-backport-unit-test-metaschema-model
branch
from
417ad9e
to
3a245cf
Compare
Yeah turns out making it less compatible was annoying, and I found a resolved bug in metaschema-framework/metaschema-java#219 and a sorta bug (really a "well, don't do that" that will lead to fixups in metaschema-framework/metaschema-java#221, but yep, there you have it. |
Rene2mt
requested changes
Oct 29, 2024
There was a problem hiding this comment.
@aj-stein-gsa this is great!!! Liking the application of metaschema and metaschema constraints this scenario.
I have a blocking change request to include the pipeline assembly reference, but aside from that, I tested locally and it looks good.
Thanks to @Rene2mt for PR feedback about the missing ref to the assembly definition of pipeline in the model. Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
Rene2mt
approved these changes
Oct 29, 2024
DimitriZhurkin
approved these changes
Oct 29, 2024
wandmagic
reviewed
Oct 29, 2024
wandmagic
pushed a commit
that referenced
this pull request
Nov 1, 2024
* [skip ci] Metaschema module for unit test struct We are proposing changes to the structure of the JSON/YAML unit test file used for all constraints test suite management. This version documents the model of that YAML file before the proposed change in the comments of the #817 PR, linked below. #817 (comment) * [skip ci] Document unit test metaschema elements * [skip ci] Do not explicitly use default types * [skip ci] Add missing `@id` and `@level` to model * [skip ci] Add pipeline to pipeline, thx @wandmagic * [skip ci] Backport #219 docs into model remarks * [skip ci] Fix max-occurs re bad model cardinality This addresses changes that should be handled as determined by upstream guidance from metaschema-framework maintainers. metaschema-framework/metaschema-java#221 metaschema-framework/metaschema#44 * [skip ci] Is a pipeline with a ref even a pipeline at all? Thanks to @Rene2mt for PR feedback about the missing ref to the assembly definition of pipeline in the model. Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov> --------- Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
brian-ruf
pushed a commit
to brian-ruf/fedramp-automation
that referenced
this pull request
Nov 8, 2024
* [skip ci] Metaschema module for unit test struct We are proposing changes to the structure of the JSON/YAML unit test file used for all constraints test suite management. This version documents the model of that YAML file before the proposed change in the comments of the GSA#817 PR, linked below. GSA#817 (comment) * [skip ci] Document unit test metaschema elements * [skip ci] Do not explicitly use default types * [skip ci] Add missing `@id` and `@level` to model * [skip ci] Add pipeline to pipeline, thx @wandmagic * [skip ci] Backport GSA#219 docs into model remarks * [skip ci] Fix max-occurs re bad model cardinality This addresses changes that should be handled as determined by upstream guidance from metaschema-framework maintainers. metaschema-framework/metaschema-java#221 metaschema-framework/metaschema#44 * [skip ci] Is a pipeline with a ref even a pipeline at all? Thanks to @Rene2mt for PR feedback about the missing ref to the assembly definition of pipeline in the model. Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov> --------- Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
This was referenced Nov 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
This PR will add a machine-readable specification of the JSON/YAML-based unit-test initiated in #593. It does not include proposed changes with team support in #817. Such a change will come in a later PR.
All Submissions:
If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated.?This is a backlog item to backport work into gaps from previous and current issues in progress on the board.If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?This is a backlog item to backport work into gaps from previous and current issues in progress on the board.By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.