Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Metaschema validation errors #857

Merged

Conversation

DimitriZhurkin
Copy link

@DimitriZhurkin DimitriZhurkin commented Nov 1, 2024

Committer Notes

In the has-security-sensitivity-level and has-security-impact-level constraints, move the <message> elements below the help-url props.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@DimitriZhurkin DimitriZhurkin requested a review from a team as a code owner November 1, 2024 14:22
@Gabeblis
Copy link

Gabeblis commented Nov 1, 2024

@DimitriZhurkin Good catch. I included this in #856, but you definitely did it the right way sir 🫡

Copy link

@Gabeblis Gabeblis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix

@Gabeblis Gabeblis requested a review from a team November 1, 2024 14:30
@aj-stein-gsa aj-stein-gsa merged commit fe36bc5 into GSA:develop Nov 1, 2024
5 checks passed
brian-ruf pushed a commit to brian-ruf/fedramp-automation that referenced this pull request Nov 8, 2024
This was referenced Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants