Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete Makefile target reference to make module that doesn't exist anymore #859

Conversation

aj-stein-gsa
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa commented Nov 4, 2024

Committer Notes

This work relates to #841 as part of the work to finalize transitions in repo part of #738.

All Submissions:

  • Have you selected the correct base branch per Contributing guidance?
  • Have you set "Allow edits and access to secrets by maintainers"?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated.? N/A for repo tooling for devs.
  • If applicable, does this PR reference the issue it addresses and explain how it addresses the issue? N/A for repo tooling for devs.

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

It turns out I left an errant Makefile target that is no longer needed.
See the removed target from the targeted Makefile module, but it was
left in the top-level targets and referenced in the still active `clean`
target.

https://github.com/GSA/fedramp-automation/pull/841/files#diff-b0fa8ca7ead097f81107867d3e7cea11f7b622267b326985e8d7f8763031ea1a
@aj-stein-gsa aj-stein-gsa added the type: backlog item For developer work that is not part of a user-facing epic or user story. label Nov 4, 2024
@aj-stein-gsa aj-stein-gsa self-assigned this Nov 4, 2024
@aj-stein-gsa aj-stein-gsa marked this pull request as ready for review November 4, 2024 14:37
@aj-stein-gsa aj-stein-gsa requested a review from a team as a code owner November 4, 2024 14:37
@aj-stein-gsa aj-stein-gsa merged commit fcdd25e into GSA:develop Nov 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: backlog item For developer work that is not part of a user-facing epic or user story.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants