Add Diagram Link Validation Constraints

[Gabeblis]

Committer Notes

Purpose

This PR introduces the implementation of three new system-characteristics constraints leveraging the functionality provided by OSCAL-CLI version 2.3. These constraints ensure that all necessary diagram links are properly validated, ensuring all diagrams have valid and accessible resource targets in the back-matter.

Changes

Constraint: has-authorization-boundary-diagram-link-href-target

• Ensures that a valid href target is specified for the authorization boundary diagram link.
• Validates the presence and correctness of the link target.

Constraint: has-network-architecture-diagram-link-href-target

• Ensures that a valid href target is specified for the network architecture diagram link.
• Validates the presence and correctness of the link target.

Constraint: has-data-flow-diagram-link-href-target

• Ensures that a valid href target is specified for the data flow diagram link.
• Validates the presence and correctness of the link target.

Tests:

• Invalid case test files were created for each constraint.
• Pass/fail case yaml files were created for each constraint.

All Submissions:

• Have you selected the correct base branch per Contributing guidance?
• Have you set "Allow edits and access to secrets by maintainers"?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Have you squashed any non-relevant commits and commit messages? [instructions]
• Have you added an explanation of what your changes do and why you'd like us to include them?
  - [ ] If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated.? Documentation already exists.
• If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

[aj-stein-gsa]

Oh I now realize this is a PR, not an issue. I will backport an issue.

[Gabeblis]

Oh I now realize this is a PR, not an issue. I will backport an issue.

I opened an issue here

[aj-stein-gsa]

Oh I now realize this is a PR, not an issue. I will backport an issue.

I opened an issue here

I just realized I was maybe tagging and adding something incorrectly to the board.

[aj-stein-gsa]

Great work, I like the dev process, tests, and their inline docs. I have minor tweaks and I will reapprove either way. Thanks for taking the time on these.

[aj-stein-gsa]

@Gabeblis can you also go the referenced page in the help-url and add an example of the inline link approach (not just a href URI reference to UUID)? It will not block this issue.

[wandmagic]

looks good but we really need a function that auto-resolves the hashes, because having so many if thens about the # character is a bit of cognitave overload, can we create functions in metapath and re-use that concept?

also would we want a more general, every resource should have a doc-available?

[Gabeblis]

looks good but we really need a function that auto-resolves the hashes, because having so many if thens about the # character is a bit of cognitave overload, can we create functions in metapath and re-use that concept?

also would we want a more general, every resource should have a doc-available?

This is just to check that a valid resource is referenced. It is not checking the actual content. As far as the cognitive overload goes, I'm always down to make things easier, but I'm not too bothered by how it is currently.

[david-waltermire]

looks good but we really need a function that auto-resolves the hashes, because having so many if thens about the # character is a bit of cognitave overload, can we create functions in metapath and re-use that concept?

The issue metaschema-framework/metaschema-java#242 is about this. This is on my short list of capabilities to add.