Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prepared For Constraints #869

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Conversation

Gabeblis
Copy link
Contributor

@Gabeblis Gabeblis commented Nov 6, 2024

Committer Notes

Purpose

This PR introduces three constraints aimed at ensuring FedRAMP compliance for the digital authorization package by verifying the prepared-for roles/parties. These constraints ensure that all required elements are present and that necessary information is accurately documented.

Changes

Constraint: role-defined-prepared-for

  • Validates that there is a defined role with the ID "prepared-for".

Constraint: responsible-party-prepared-for

  • Ensures that a responsible party is assigned to the prepared-for role.

Constraint: responsible-party-prepared-for-location-valid

  • Validates that the party assigned to the prepared-for role includes a location-uuid with the required address details.

Tests

  • Added invalid test data files for all three constraints.
  • Added pass/fail YAML files for the three constraints to verify their functionality.
  • Updated ssp-all-VALID.xml to contain the required information so that the constraints fire and pass as expected.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Nov 6, 2024
@Gabeblis Gabeblis requested a review from a team as a code owner November 6, 2024 05:14
@Gabeblis Gabeblis linked an issue Nov 6, 2024 that may be closed by this pull request
17 tasks
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you address the updated AC requirements in the issue? Sorry again.

@Gabeblis
Copy link
Contributor Author

Gabeblis commented Nov 6, 2024

Can you address the updated AC requirements in the issue? Sorry again.

Resolved here: 045e70e. I added the check for an embedded address assembly in the party and I added another -VALID.xml test file in order to validate both scenarios.

@Gabeblis Gabeblis requested a review from aj-stein-gsa November 6, 2024 17:03
wandmagic
wandmagic previously approved these changes Nov 6, 2024
@aj-stein-gsa aj-stein-gsa mentioned this pull request Nov 7, 2024
7 tasks
@Gabeblis Gabeblis force-pushed the constraints/prepared-for branch from 55272cc to dc6750a Compare November 7, 2024 15:21
@Gabeblis Gabeblis mentioned this pull request Nov 8, 2024
6 tasks
@Gabeblis Gabeblis force-pushed the constraints/prepared-for branch 3 times, most recently from b7ee57f to 7c81ede Compare November 8, 2024 22:22
@Gabeblis Gabeblis requested review from wandmagic, aj-stein-gsa and a team November 8, 2024 22:25
wandmagic
wandmagic previously approved these changes Nov 12, 2024
Copy link

@kyhu65867 kyhu65867 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tweaks to message clarity

aj-stein-gsa
aj-stein-gsa previously approved these changes Nov 12, 2024
@Gabeblis Gabeblis dismissed stale reviews from aj-stein-gsa and wandmagic via c67e133 November 13, 2024 13:55
@Gabeblis Gabeblis force-pushed the constraints/prepared-for branch from c67e133 to cb9cb90 Compare November 13, 2024 13:58
@Gabeblis Gabeblis requested a review from kyhu65867 November 13, 2024 13:58
aj-stein-gsa
aj-stein-gsa previously approved these changes Nov 13, 2024
@aj-stein-gsa
Copy link
Contributor

@Gabeblis sorry to be that person, but can you rebase?

@Gabeblis Gabeblis requested a review from a team November 13, 2024 16:11
@Gabeblis Gabeblis merged commit 9652ef6 into GSA:develop Nov 14, 2024
5 checks passed
@Gabeblis Gabeblis deleted the constraints/prepared-for branch November 14, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check "prepared for" metadata for a document
5 participants