Add has-marking

[DimitriZhurkin]

Committer Notes

1. Add the has-marking constraint to check the existence of the <prop name="marking" value="cui"/> metadata prop.
2. Add the allowed value for the marking metadata prop.
3. Add the marking metadata prop to ssp-all-VALID.xml file.
4. Add pass and fail unit test.

All Submissions:

• Have you selected the correct base branch per Contributing guidance?
• Have you set "Allow edits and access to secrets by maintainers"?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Have you squashed any non-relevant commits and commit messages? [instructions]
• Have you added an explanation of what your changes do and why you'd like us to include them?
• If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated.?
• If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

[DimitriZhurkin]

Issue #836.

[aj-stein-gsa]

@DimitriZhurkin why did you close this PR?

[DimitriZhurkin]

Because its workflows didn't appear on the Actions tab.

I tried recreating it locally, and all hell broke loose. Now my local repository is screwed up completely.

I reopened this PR.

[wandmagic]

looks good to me, just rebase before merging

[DimitriZhurkin]

I did rebase my local repo. I also did hard reset, just in case.

[DimitriZhurkin]

Paul,

How do I remove the erroneously generated | marking | entry from fedramp_extensions.feature? That entry crashes the workflows for this PR.

I tried removing marking from fedramp_extensions.feature manually, but VS Code threw the following error:
Can't push refs to remote. Try running "Pull" first to integrate your changes.

When I pull, I'm getting the following message:
Already up to date.

[DimitriZhurkin]

Still the same workflow run error:

Ensuring full test coverage for "marking": OSCAL Document Constraints
Constraint marking has no tests
AssertionError: Constraint marking has no tests

[aj-stein-gsa]

I have a minor wording nit, but I am happy this. I would

[Rene2mt]

PR looks good, but waiting for suggestions to be merged and the documentation PR to be updated, then I'll approve

[aj-stein-gsa]

Oh and @DimitriZhurkin when you find this PR I clean up things because I misled led you. Locally on your computer if you want to make changes and not just in GitHub before moving onto the website PR requested in #875 (comment):

# I am not sure you are still on this branch right now, but just to make sure
git checkout add-has-marking
git fetch origin
git stash
git reset --hard origin/add-has-marking

[kyhu65867]

This looks good to me. Nice work!

[DimitriZhurkin]

PR looks good, but waiting for suggestions to be merged and the documentation PR to be updated, then I'll approve

Documentation created (GSA/automate.fedramp.gov#110).

[DimitriZhurkin]

I have a minor wording nit, but I am happy this. I would

Wording changes implemented.