Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add has-published-date constraint #886

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

Gabeblis
Copy link

Committer Notes

Purpose

This PR introduces a validation constraint to ensure that each document submitted for FedRAMP authorization contains a valid publication date.

Changes

Constraint: has-published-date

  • Validates that a published element exists.

Tests

  • Added an invalid test data file for the above constraint.
  • Added pass/fail YAML files for the above constraint to verify their functionality.

All Submissions:

  • Have you selected the correct base branch per Contributing guidance?
  • Have you set "Allow edits and access to secrets by maintainers"?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Have you added an explanation of what your changes do and why you'd like us to include them?
    - [ ] If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated.? No updates needed. Documentation exists.
  • If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Nov 11, 2024
@Gabeblis Gabeblis requested a review from a team as a code owner November 11, 2024 16:44
@Gabeblis Gabeblis linked an issue Nov 11, 2024 that may be closed by this pull request
14 tasks
aj-stein-gsa
aj-stein-gsa previously approved these changes Nov 12, 2024
wandmagic
wandmagic previously approved these changes Nov 12, 2024
kyhu65867
kyhu65867 previously approved these changes Nov 12, 2024
Copy link

@kyhu65867 kyhu65867 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@aj-stein-gsa aj-stein-gsa dismissed stale reviews from kyhu65867, wandmagic, and themself via 4652ce0 November 13, 2024 03:37
@aj-stein-gsa aj-stein-gsa merged commit a040de7 into GSA:develop Nov 13, 2024
5 checks passed
This was referenced Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check that published data defined for digital authorization package documents
4 participants