Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise inter-boundary-component-has-direction constraint (#930) #988

Conversation

DimitriZhurkin
Copy link

@DimitriZhurkin DimitriZhurkin commented Dec 10, 2024

Committer Notes

  1. In fedramp-external-constraints.xml, modify the target Metapath expression (the inter-boundary-component variable).
  2. Update ssp-inter-boundary-component-has-direction-INVALID.xml to reflect Metapath changes.

Related issue: #930

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@DimitriZhurkin DimitriZhurkin self-assigned this Dec 10, 2024
@DimitriZhurkin DimitriZhurkin requested a review from a team as a code owner December 10, 2024 18:46
wandmagic
wandmagic previously approved these changes Dec 10, 2024
Gabeblis
Gabeblis previously approved these changes Dec 11, 2024
@Gabeblis Gabeblis requested review from wandmagic, Gabeblis, aj-stein-gsa and a team December 12, 2024 16:54
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like this PR not get merged until we confirm this implements the updated in a comment but not modified in the issue criteria per #930 (comment). I just want confirmation that this is "the place" where that goes because thus far the new requirements were discussed separate of which issue, this seems like one possible place. If I get corrected by someone on the team, I will dismiss and approve.

@aj-stein-gsa aj-stein-gsa changed the title Revise inter-boundary-component-has-direction constraint (#930) [DONOTMERGE] Revise inter-boundary-component-has-direction constraint (#930) Dec 12, 2024
@aj-stein-gsa aj-stein-gsa changed the title [DONOTMERGE] Revise inter-boundary-component-has-direction constraint (#930) Revise inter-boundary-component-has-direction constraint (#930) Dec 12, 2024
@aj-stein-gsa
Copy link
Contributor

I only delinked #930 so it does not automatically close the issue because there are potentially multiple requirements for that set of constraints, I do not want to automatically close. I am about to re-review.

@DimitriZhurkin DimitriZhurkin merged commit 4859c3f into GSA:develop Dec 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants