Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inter-boundary-component-direction-incoming-has-ipv-uri constraint (#930) #994

Conversation

DimitriZhurkin
Copy link

@DimitriZhurkin DimitriZhurkin commented Dec 12, 2024

Committer Notes

This constraint tests the following scenario:
If direction is incoming, there must be at least one local ipv4 address, ipv6 address, or a URI to an API.

Related issue #930.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@DimitriZhurkin DimitriZhurkin requested a review from a team as a code owner December 12, 2024 21:23
@DimitriZhurkin DimitriZhurkin self-assigned this Dec 12, 2024
@DimitriZhurkin DimitriZhurkin changed the title [DONOTMERGE] Add inter-boundary-component-direction-incoming-has-ipv-uri constraint [DONOTMERGE] Add inter-boundary-component-direction-incoming-has-ipv-uri constraint (#930) Dec 12, 2024
@DimitriZhurkin DimitriZhurkin changed the title [DONOTMERGE] Add inter-boundary-component-direction-incoming-has-ipv-uri constraint (#930) Add inter-boundary-component-direction-incoming-has-ipv-uri constraint (#930) Dec 13, 2024
Copy link
Contributor

@Gabeblis Gabeblis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@wandmagic wandmagic merged commit d8267e3 into GSA:develop Dec 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Components representing inter-boundary communication need to declare the direction of data flow
3 participants