Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use psycopg2==2.8.4 in bionic #23

Merged
merged 3 commits into from
Mar 18, 2020
Merged

Use psycopg2==2.8.4 in bionic #23

merged 3 commits into from
Mar 18, 2020

Conversation

FuhuXia
Copy link
Member

@FuhuXia FuhuXia commented Mar 3, 2020

fixed issue GSA/data.gov#1375 and workaround for GSA/data.gov#961

@FuhuXia FuhuXia requested a review from a team March 3, 2020 19:52
@mogul
Copy link
Contributor

mogul commented Mar 3, 2020

The change looks fine but the test is failing:

Creating project_test_1 ... done
Attaching to project_test_1
test_1       | 1..4
test_1       | not ok 1 app container is up
test_1       | # (from function `wait_for' in file tests/test.bats, line 13,
test_1       | #  in test file tests/test.bats, line 35)
test_1       | #   `wait_for app 5000' failed
test_1       | # nc: bad address 'app'
test_1       | # nc: bad address 'app'
test_1       | # nc: bad address 'app'
test_1       | # nc: bad address 'app'
test_1       | # nc: bad address 'app'
test_1       | # nc: bad address 'app'
test_1       | # nc: bad address 'app'
test_1       | # nc: bad address 'app'
test_1       | not ok 2 /user/login is up
test_1       | # (in test file tests/test.bats, line 39)
test_1       | #   `curl --silent --fail http://app:5000/user/login' failed with status 6
test_1       | not ok 3 data is accessible for user
test_1       | # (from function `test_login_and_datasets' in file tests/test.bats, line 23,
test_1       | #  in test file tests/test.bats, line 43)
test_1       | #   `test_login_and_datasets' failed with status 6
test_1       | not ok 4 data is inaccessible to public
test_1       | # (in test file tests/test.bats, line 49)
test_1       | #   `[ "$status" -eq 22 ]' failed with status 6
project_test_1 exited with code 1
Aborting on container exit...
make: *** [test] Error 1

Exited with code exit status 2

@jbrown-xentity
Copy link
Contributor

Something is now causing inventory to break every time, same error. Doesn't matter what branch I'm using, they have all started breaking. It must be occurring because of something external, otherwise why would every branch be failing? See thread in datagov-ckan-multi in slack...

@adborden
Copy link
Contributor

Hey folks, I thought 2.8.4 was causing GSA/data.gov#961. Why are we trying to update it?

@FuhuXia
Copy link
Member Author

FuhuXia commented Mar 10, 2020

@adborden because 2.7.7 creates a more critical issue GSA/data.gov#1375. we can use 2.8.4 as along as we skip database tag. if we need run db init command, we have to temporally use 2.7.7 then switch back to 2.8.4 afterwards. that is the workaround I found.

@adborden
Copy link
Contributor

Nm, I see the work around for GSA/data.gov#961 is what caused GSA/data.gov#1375. Unfortunately, that means without the work around, we can't initialize the db for the automated tests.

@FuhuXia FuhuXia merged commit d5262eb into bionic Mar 18, 2020
@FuhuXia FuhuXia deleted the bionic-psycopg2-2-8-4 branch March 18, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants