PY3 extension upgrade #350
Conversation
…th main inventory-app
There was a problem hiding this comment.
Looking good, but a few more things to do.
We need to get the extension installed in cloud.gov; we can either install it in the cfstart script (my preference) or add it to the requirements install.
We'll also need to enable the extension in the production.ini file.
| 'revision_list': datagov_disallow_anonymous_access(), | ||
| 'revision_show': datagov_disallow_anonymous_access(), | ||
| 'package_show': datagov_disallow_anonymous_access(), | ||
| 'resource_show': datagov_allow_anonymous_access, |
There was a problem hiding this comment.
I think we just want to add package_show and resource_show, right?
There was a problem hiding this comment.
I put a comment on the issue ticket, but there revision history is no longer supported, so those keywords no longer exist either..
| cy.visit('/dataset'); | ||
| }); |
There was a problem hiding this comment.
Do we still want this line here?
There was a problem hiding this comment.
It was to make sure the fixture was captured in the right test. Without this line, the fixture was just run as part of the next test. I don't know if we can write the test differently to capture the fixture properly.
| cy.delete_dataset('test-dataset-1') | ||
| cy.delete_organization('test-organization') | ||
| }) | ||
|
|
||
| it('Cannot access the standard public pages', () => { | ||
| cy.logout(); | ||
| cy.request({ | ||
| url: '/dataset', | ||
| failOnStatusCode: false | ||
| }).then((response) => { | ||
| // TODO: local extension should return 403 on anonymous access |
There was a problem hiding this comment.
We can delete this line too!
There was a problem hiding this comment.
By "this", I mean this line: // TODO: local extension should return 403 on anonymous access
| @@ -1,15 +1,12 @@ | |||
| describe('Login', () => { | |||
|
|
|||
| it('Invalid user login attempt', () => { | |||
| cy.visit('/dataset') | |||
| cy.get('a[href="/user/login"]').click() | |||
| cy.visit('/user/login') | |||
There was a problem hiding this comment.
Don't need this, it's handled in the cy.login command
| # TODO: re-integrate datagov_inventory, dcat_usmetadata, usmetadata, datajson, saml2auth | ||
| ckan.plugins = datastore xloader stats text_view recline_view googleanalyticsbasic s3filestore envvars | ||
| # TODO: re-integrate dcat_usmetadata, usmetadata, datajson, saml2auth | ||
| ckan.plugins = datagov_inventory datastore xloader stats text_view recline_view googleanalyticsbasic s3filestore envvars |
There was a problem hiding this comment.
This is all good, but it's not added to production.ini
|
Also, would be nice if we could pin pygments to pygments@2.7.4 in the dev requirements, snyk has multiple vulnerabilities with that (it's pulled in via sphinx and ipdb). Or try unpinning sphinx and ipdb... This may break python2/ckan2.8, but |
PR for GSA/data.gov#3388