Inventory simple up and data seeding #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrown-xentity
requested review from
adborden and
a team
and removed request for
adborden
adborden
suggested changes
Jan 2, 2020
There was a problem hiding this comment.
Thanks!
Script looks good. The docker commands should be switched to docker-compose and the docs updated. It's rare that you need a raw docker command.
Can you also add running of the seed command to the test setup so it's run as part of CI?
... and a review of #3 which adds a minimal integration test?
adborden
approved these changes
Jan 2, 2020
chris-macdermaid
added a commit
that referenced
this pull request
Feb 1, 2021
chris-macdermaid
added a commit
that referenced
this pull request
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers implementation for items: