Upgrade terraform-cloudgov module

[jskinne3]

Description

Upgrade terraform-cloudgov module from v0.7.1 to v0.9.1 in two locations:

1. bootstrap module
2. sandbox module

The same change will be made in deployed environments once it is proven in the above.

Reason

The terraform-cloudgov module has an open issue to remove the deprecated recursive_delete argument and replace it with more modern notation. We want to be prepared to make use of this change when it is made, particularly in the bootstrap module, where we want to protect Terraform's state bucket. So let's validate the intermediate versions by upgrading now.

Ideally we would use the prevent_destroy argument (which is used within the lifecycle meta-argument) when we invoke @rahearn's module, rather than pass a flag to his module and ask the module to do it. But, Terraform only allows the lifecycle meta-argument in a resource definition, not a module.

[github-actions]

Terraform Format and Style: success
Terraform Initialization: success
Terraform Validation: success
Terraform Plan: success

Show Plan

module.ses_email.data.cloudfoundry_service.ses: Reading...
module.csv_upload_bucket.data.cloudfoundry_space.space: Reading...
module.database.data.cloudfoundry_space.space: Reading...
module.ses_email.data.cloudfoundry_space.space: Reading...
module.redis.data.cloudfoundry_space.space: Reading...
module.egress-space.data.cloudfoundry_org.org: Reading...
module.sns_sms.data.cloudfoundry_space.space: Reading...
module.csv_upload_bucket.data.cloudfoundry_service.s3: Reading...
module.sns_sms.data.cloudfoundry_service.sns: Reading...
module.redis.data.cloudfoundry_service.redis: Reading...
module.sns_sms.data.cloudfoundry_service.sns: Read complete after 1s [id=9c59e780-af5a-4a89-ac31-591a3ae1347e]
module.database.data.cloudfoundry_service.rds: Reading...
module.csv_upload_bucket.data.cloudfoundry_service.s3: Read complete after 1s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b]
module.ses_email.data.cloudfoundry_service.ses: Read complete after 1s [id=b41dc2f2-7825-4a8e-987a-ce87a161e670]
module.egress-space.data.cloudfoundry_org.org: Read complete after 1s [id=9e428562-a2d9-41b4-9c23-1ef5237fb44e]
module.egress-space.data.cloudfoundry_user.users["3416d155-a1eb-4953-bc79-76712aaa7910"]: Reading...
module.egress-space.data.cloudfoundry_user.users["steven.reilly@gsa.gov"]: Reading...
module.egress-space.cloudfoundry_space.public_egress: Refreshing state... [id=21b58751-362b-433a-a285-8a1455d9634f]
module.redis.data.cloudfoundry_service.redis: Read complete after 1s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.egress-space.data.cloudfoundry_user.users["carlo.costino@gsa.gov"]: Reading...
module.sns_sms.data.cloudfoundry_space.space: Read complete after 1s [id=9745decb-4988-4bab-88a4-e3f07b36241c]
module.sns_sms.cloudfoundry_service_instance.sns: Refreshing state... [id=d09f8305-42c1-4b74-820e-5479cdcf515a]
module.database.data.cloudfoundry_space.space: Read complete after 1s [id=9745decb-4988-4bab-88a4-e3f07b36241c]
module.ses_email.data.cloudfoundry_space.space: Read complete after 1s [id=9745decb-4988-4bab-88a4-e3f07b36241c]
module.ses_email.cloudfoundry_service_instance.ses: Refreshing state... [id=bc6b3f0b-dc2f-4b46-84d1-3940c29693d7]
module.redis.data.cloudfoundry_space.space: Read complete after 1s [id=9745decb-4988-4bab-88a4-e3f07b36241c]
module.redis.cloudfoundry_service_instance.redis: Refreshing state... [id=ebcfe297-b76f-4d71-a6a7-bf6c12b2587c]
module.csv_upload_bucket.data.cloudfoundry_space.space: Read complete after 1s [id=9745decb-4988-4bab-88a4-e3f07b36241c]
module.csv_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=b15631b3-00fb-49f6-a4d3-ebaedfca1cd9]
module.database.data.cloudfoundry_service.rds: Read complete after 0s [id=dcfb1d43-f22c-42d3-962c-7ae04eda24e7]
module.database.cloudfoundry_service_instance.rds: Refreshing state... [id=b8caaa4f-b3b8-4dbc-ba16-95d3899be5a0]
module.egress-space.data.cloudfoundry_user.users["steven.reilly@gsa.gov"]: Read complete after 0s [id=ffd00a3e-aa1a-42e1-a81a-5f60420658c2]
module.egress-space.data.cloudfoundry_user.users["3416d155-a1eb-4953-bc79-76712aaa7910"]: Read complete after 0s [id=bd05a408-f276-4f68-9fa6-efc89442a642]
module.egress-space.data.cloudfoundry_user.users["carlo.costino@gsa.gov"]: Read complete after 0s [id=c7b9f5e0-4d1b-43b1-a659-e8fe4f7083a8]
module.egress-space.cloudfoundry_space_users.deployers: Refreshing state... [id=3fbb7982-1e77-4219-cc78-986468887dd7]

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Warning: Argument is deprecated

  with module.ses_email.cloudfoundry_service_instance.ses,
  on ../shared/ses/main.tf line 22, in resource "cloudfoundry_service_instance" "ses":
  22:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 4 more similar warnings elsewhere)

Pusher: @jskinne3, Action: pull_request

[ccostino]

Thanks, @jskinne3! This is good to go when we're ready to merge. Thank you for the clear write-up and reasoning behind what's going on, too!