Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all cy.wait values in pipeline #1863

Closed
1 task
scottqueen-bixal opened this issue Oct 10, 2024 · 1 comment · Fixed by #1965
Closed
1 task

Remove all cy.wait values in pipeline #1863

scottqueen-bixal opened this issue Oct 10, 2024 · 1 comment · Fixed by #1965
Assignees
@nehemiah-abuga
Labels
V1 Final V1 handoff work

Comments

@scottqueen-bixal
Copy link
Collaborator

Description

let's opt over to checks rather than arbitrary times on cypress async tasks

ie. get by update in DOM

cy.get([data-testid="dom-ready"])

User Story

No response

Acceptance Criteria

  • no cy.wait used in testst
@scottqueen-bixal scottqueen-bixal added the V1 Final V1 handoff work label Oct 10, 2024
@scottqueen-bixal scottqueen-bixal mentioned this issue Nov 12, 2024
Closed
@nehemiah-abuga nehemiah-abuga mentioned this issue Nov 25, 2024
Merged
4 tasks
@nehemiah-abuga
Copy link
Collaborator

This is ready for review #1965

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nehemiah-abuga nehemiah-abuga

Labels
V1 Final V1 handoff work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PXBF-1863-cypress-remove-cy-wait: refactoring cypress tests to remove… GSA/px-benefit-finder
2 participants
@scottqueen-bixal @nehemiah-abuga