Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PXBF-1863-cypress-remove-cy-wait: refactoring cypress tests to remove… #1965

Merged
merged 3 commits into from
Dec 9, 2024
Merged

PXBF-1863-cypress-remove-cy-wait: refactoring cypress tests to remove… #1965

merged 3 commits into from
Dec 9, 2024

Conversation

nehemiah-abuga
Copy link
Collaborator

… waits

PR Summary

  • This PR refactors multiple Cypress test scenarios to eliminate the use of unnecessary cy.wait() commands, improving test reliability and execution speed.
  • Hardcoded cy.wait() calls has been replaced with dynamic checks based on window.dataLayer updates.
  • In addition, utilized Cypress’s cy.window() and cy.wrap commands to validate events efficiently.
  • Removed unnecessary eslint-disable comments.

Related Github Issue

Detailed Testing steps

  • pull changes locally
  • cd benefit finder
  • npm run dev:storybook
  • cy:run:e2e and verify all test pass

@nehemiah-abuga nehemiah-abuga mentioned this pull request Nov 25, 2024
Closed
1 task
@scottqueen-bixal
PXBF-1863-cypress-remove-cy-wait: Merge branch 'dev' of github.com:GS…
a2150a0 
…A/px-benefit-finder into 1863-cypress-remove-cy-wait
@nehemiah-abuga
PXBF-1863-cypress-remove-cy-wait: combine processes
adc703b 
combine processes reduce repetitive tasks
@scottqueen-bixal scottqueen-bixal merged commit 69d5960 into dev Dec 9, 2024
5 checks passed
@scottqueen-bixal scottqueen-bixal deleted the 1863-cypress-remove-cy-wait branch December 9, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottqueen-bixal scottqueen-bixal scottqueen-bixal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove all cy.wait values in pipeline
2 participants
@nehemiah-abuga @scottqueen-bixal