Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1575 update life event controller dependency injection #1649

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

gchi25
Copy link
Collaborator

@gchi25 gchi25 commented Aug 6, 2024

PR Summary

This work updates life event controller dependency injection.

Related Github Issue

Detailed Testing steps

To test in local development site or in dev site.

  • Pull changes locally
  • Make local development site up at http://localhost
  • In local, $ docker restart cms
  • In local, $ bin/drush cr
  • Navigate to admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
  • Go to life event form "Benefit finder: death of a loved one" edit page
  • Change Time Estimate to 10-20 minutes
  • Save as published
  • Verify that the system generates both draft and published JSON files

image

  • Go to app draft mode: benefit-finder/death?mode=draft
  • Verify estimated time 10-20 minutes
  • Go to app published mode: benefit-finder/death
  • Verify estimated time 10-20 minutes

image

  • Open code diff site: https://www.w3docs.com/tools/code-diff/
  • Open JSON formatter site: https://jsonformatter.org/
  • Get JSON data from https://www.usa.gov/s3/files/benefit-finder/api/life-event/death.json
  • Format JSON data and put data into left panel of code diff site
  • Get JSON data from s3/files/benefit-finder/api/life-event/death.json
  • Format JSON data and put data into right panel of code diff site
  • Compare JSON data
  • Verify that their data structures are same besides some content difference due to the difference of your testing site database and USA prod database

Content updated in estimated time field
image

Content updated with an option removed
image

Content updated
image

@gchi25 gchi25 self-assigned this Aug 6, 2024
Copy link
Collaborator

@nehemiah-abuga nehemiah-abuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Approved

@gchi25 gchi25 marked this pull request as draft August 15, 2024 00:07
@gchi25 gchi25 changed the title 1575 update life event controller 1575 update life event controller dependency injection Aug 15, 2024
@gchi25 gchi25 requested review from scottqueen-bixal and nehemiah-abuga and removed request for scottqueen-bixal and nehemiah-abuga August 22, 2024 15:01
@gchi25 gchi25 marked this pull request as ready for review August 26, 2024 16:31
@gchi25 gchi25 merged commit c18e591 into dev Aug 26, 2024
7 checks passed
@gchi25 gchi25 deleted the 1575-update-lifeevent-controller branch August 26, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update life event controller with dependency injection
2 participants