Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting the CSV Download based on the table filtering #149

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

BuckinghamAJ
Copy link
Collaborator

Changes

  • When exporting the CSV, it will now take into account the filters you have placed on the table.

Copy link
Collaborator

@collinschreyer-dev collinschreyer-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional suggestion: adding a brief description of the filters parameter within the method’s comment block could enhance readability and support future developers coming into the project--like me haha. That said, the addition of the filters parameter is a good enhancement!

@BuckinghamAJ BuckinghamAJ merged commit f407fa9 into dev Nov 4, 2024
1 check passed
@BuckinghamAJ BuckinghamAJ deleted the feature/15_export_csv_filters branch November 4, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants