Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to pass tfrmt/data as arguments #85

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Allow users to pass tfrmt/data as arguments #85

merged 4 commits into from
Aug 2, 2024

Conversation

bzkrouse
Copy link
Collaborator

resolves #52

@bzkrouse bzkrouse requested a review from karima662 July 30, 2024 13:17
@bzkrouse
Copy link
Collaborator Author

bzkrouse commented Aug 2, 2024

@karima662 I am going to merge this to main but would still appreciate the review! Just please use main branch to test.

@bzkrouse bzkrouse merged commit baa1573 into main Aug 2, 2024
10 checks passed
@karima662
Copy link
Collaborator

karima662 commented Aug 2, 2024

@bzkrouse looks good 👍

Might be worth automatically setting mockmode to FALSE when something is supplied to the data parameter, or adding a message to alert the user.

@bzkrouse bzkrouse deleted the pass-data branch September 22, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider adding arguments in tfrmtbuilder() to load data
2 participants