This repository has been archived by the owner on Dec 7, 2024. It is now read-only.
312 delete notice #313
Merged
312 delete notice #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ta2ye0n
requested review from
louis7308,
Huuuunee,
dolong2,
yoonjibin,
KimTaeO,
JuuuuHong and
ani2689
as code owners
ani2689
reviewed
Apr 2, 2024
src/main/kotlin/com/msg/gcms/domain/notice/service/impl/DeleteNoticeServiceImpl.kt
Outdated
Show resolved
Hide resolved
|
security config์ url์ ์ถ๊ฐํด์ฃผ์์๊น์? ๋ณ๊ฒฝ์ฌํญ์๋ ๋ณด์ด์ง ์๋ค์ ๐ฅ |
KimTaeO
reviewed
Apr 2, 2024
| @@ -25,4 +28,11 @@ class NoticeController( | |||
| .let { createNoticeService.execute(clubId, it) } | |||
| .let { ResponseEntity.status(HttpStatus.CREATED).build() } | |||
|
|
|||
| @DeleteMapping("/{id}") | |||
| fun deleteNotice( | |||
| @PathVariable("id") id: Long | |||
There was a problem hiding this comment.
๊ตณ์ด ๋ช ์ ์ํด์ค๋ ๋ ๊ฒ ๊ฐ์์
There was a problem hiding this comment.
5eb6382
์์ ํ์ต๋๋ค
Comment on lines
24
to
27
| val notice = noticeRepository.findByIdOrNull(id) | ||
| ?: throw NoticeNotFoundException() | ||
|
|
||
| noticeRepository.delete(notice) |
There was a problem hiding this comment.
๋จผ์ ์ํฐํฐ๋ฅผ ์ฐพ๊ณ delete ๋ฉ์๋์ ๋๊ธฐ๋ ๋ฐฉ์์ผ๋ก ์์ฑํ์ จ๋๋ฐ ์ด๋ ๊ฒ ํ๋ฉด delete ๋ด๋ถ ๊ตฌํ์ฒด์์ find ์ฟผ๋ฆฌ๋ฅผ ๋ฐ์ ์ํค๊ธฐ ๋๋ฌธ์ deleteById๋ฅผ ์ฌ์ฉํ๋๊ฒ ์ด๋จ๊น ์ถ๋ค์
There was a problem hiding this comment.
47105b8
์์ ํ์ต๋๋ค
ani2689
approved these changes
Apr 2, 2024
KimTaeO
approved these changes
Apr 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ก ๊ฐ์
๊ณต์ง์ฌํญ ์ญ์ api๋ฅผ ๊ตฌํํ์ต๋๋ค
๐ ์์ ๋ด์ฉ