Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔀 :: Major Selector 만들기 #125

Merged
merged 14 commits into from
May 24, 2023
Merged

🔀 :: Major Selector 만들기 #125

merged 14 commits into from
May 24, 2023

Conversation

kimsh153
Copy link
Member

@kimsh153 kimsh153 commented May 24, 2023 •
edited
Loading

💡 개요

Major Selector 만들기

📃 작업내용

  • Major Selector Bottom Sheet 만들기
  • 직접입력 추가
  • 컴포넌트 분리
  • BottomSheet topPadding으로 maxHeight 고정시키기기
스크린샷 2023-05-24 오후 7 20 03

@kimsh153 kimsh153 added 1️⃣ Priority: High 우선순위 - 상 ✨ Feature 신규 기능 labels May 24, 2023
@kimsh153 kimsh153 self-assigned this May 24, 2023
@kimsh153 kimsh153 requested a review from baekteun as a code owner May 24, 2023 10:20
@kimsh153 kimsh153 linked an issue May 24, 2023 that may be closed by this pull request
전공 리스트 Selector 제작 #124
Closed
baekteun
baekteun reviewed May 24, 2023
View reviewed changes
Projects/Feature/InputProfileInfoFeature/Sources/Model/InputProfileInfoModel.swift Outdated
Comment on lines 59 to 61
}
func updateProfileImage(imageResult: PickedImageResult?) {
self.profileImage = imageResult
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
func updateProfileImage(imageResult: PickedImageResult?) {
self.profileImage = imageResult
}
func updateProfileImage(imageResult: PickedImageResult?) {
self.profileImage = imageResult

줄바꿈해주세여

baekteun
baekteun requested changes May 24, 2023
View reviewed changes
Copy link
Member

@baekteun baekteun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

서버통신도 해주세요.

@kimsh153 kimsh153 merged commit 6c5cf13 into master May 24, 2023
@kimsh153 kimsh153 deleted the 124-major-list-seletar branch May 24, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baekteun baekteun baekteun approved these changes

Assignees

@kimsh153 kimsh153

Labels
1️⃣ Priority: High 우선순위 - 상 ✨ Feature 신규 기능
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

전공 리스트 Selector 제작
2 participants
@kimsh153 @baekteun