Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔀 :: AuthDomainError를 API명세서와 동일하게 수정합니다 #141

Merged
merged 2 commits into from
May 29, 2023

Conversation

baekteun
Copy link
Member

💡 개요

명세서에 맞게 400, 401, 404를 GAuth 로그인에서 실패한것으로 처리합니다.

📃 작업내용

  • invalidGAuthCode 에러 -> failedToGAuthSignin 에러 로 이름 변경
  • AuthEndpoint에서 400, 401, 404의 에러를 failedToGAuthSignin으로 설정

@baekteun baekteun added 1️⃣ Priority: High 우선순위 - 상 ♻️ Refactor 코드 리팩토링 labels May 26, 2023
@baekteun baekteun requested a review from kimsh153 as a code owner May 26, 2023 14:00
@baekteun baekteun self-assigned this May 26, 2023
@baekteun baekteun linked an issue May 26, 2023 that may be closed by this pull request
@baekteun baekteun merged commit 7de3f0a into master May 29, 2023
@baekteun baekteun deleted the 85-authdomainerror-is-missed-api-spec branch May 29, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1️⃣ Priority: High 우선순위 - 상 ♻️ Refactor 코드 리팩토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AuthDomainError가 명세서랑 다른거 같습니다.
2 participants