Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: ๋ฉ”์ธ ํŽ˜์ด์ง€ ์ œ์ž‘ #173

Merged
merged 33 commits into from
Jun 12, 2023

Conversation

kimsh153
Copy link
Member

๐Ÿ’ก ๊ฐœ์š”

๋ฉ”์ธ ํŽ˜์ด์ง€ ์ œ์ž‘

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • ๋ฉ”์ธ ํŽ˜์ด์ง€ ํผ๋ธ”๋ฆฌ์‹ฑ
  • emdpoint ๋ฒ„์ „ 3.2.11๋กœ ์—…
  • ๋ฉ”์ธ ํŽ˜์ด์ง€ API ์—ฐ๋™

kimsh153 added 24 commits May 30, 2023 01:47
@kimsh153 kimsh153 added 0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ - ๊ธด๊ธ‰!!!!! โœจ Feature ์‹ ๊ทœ ๊ธฐ๋Šฅ labels Jun 12, 2023
@kimsh153 kimsh153 requested a review from baekteun as a code owner June 12, 2023 08:19
@kimsh153 kimsh153 self-assigned this Jun 12, 2023
@kimsh153 kimsh153 linked an issue Jun 12, 2023 that may be closed by this pull request
@@ -30,6 +30,7 @@ final class InputInformationIntent: InputInformationIntentProtocol {
}

func completeToInputAllInfo(state: any InputInformationStateProtocol) {
model?.updateIsCompleteToInputAllInfo(isComplete: false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์–ด ์ด๊ฑฐ guard์—์„œ return๋‹นํ•˜๋ฉด ๊ทธ๋•Œ false๋กœ ๋ฐ”๊พธ๋Š”๊ฒŒ ๋” ์ ์ ˆํ• ๊ฑฐ๊ฐ™์€๋ฐ ์˜ฎ๊ฒจ์ฃผ์„ธ์—ฌ ^^7

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋„ต ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค

โ€ฆ.swift

Co-authored-by: baegteun <baegteun@gmail.com>
Comment on lines 21 to 29
Task {
if !isLast {
let studentList = try await fetchStudentListUseCase.execute(req: .init(page: page, size: 20))
model?.appendContent(content: studentList.studentList)
model?.updateTotalSize(totalSize: studentList.totalSize)
model?.updatePage(page: page + 1)
model?.updateIsLast(isLast: studentList.isLast)
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Task ์ƒ์„ฑํ•˜๋Š”๊ฑฐ๋งŒ์œผ๋กœ๋„ cost๊ฐ€ ๋“œ๋‹ˆ Task๋งŒ๋“ค๊ธฐ ์ „์— isLast ๊ฒ€์‚ฌํ•˜๋Š”๊ฑฐ ์–ด๋– ๊ฐ„์š”? ๊ทธ๋ฆฌ๊ณ  guard๋กœ ๊ฒ€์‚ฌํ•˜๋Š”๊ฒŒ ์ข‹์„๊ฑฐ๊ฐ™์•„์š”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ข‹์€๊ฑฐ ๊ฐ™์Šต๋‹ˆ๋‹ค! ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค

@Published var totalSize: Int = 0
@Published var isLast: Bool = false
@Published var isError: Bool = false
@Published var isSuccess: Bool = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ˜น์‹œ isSuccess ์–ด๋–ค์šฉ๋„์ธ๊ฐ€์š”?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์–ด ์‚ญ์ œํ•˜์˜€์Šต๋‹ˆ๋‹ค

Comment on lines 15 to 21
@State var testString: [String] = ["asfds1234", "12313212w33", "43534545"]
@State private var textSizes: [Int: CGSize] = [:]
@State private var truncatedIndices: [Int] = []
@State private var shouldTruncateLastText = false
@State private var breakIndex = 0
@State private var textEmpty = false

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์‚ญ์ œํ•˜์˜€์Šต๋‹ˆ๋‹ค

Comment on lines 72 to 73
}
ToolbarItem(placement: .topBarTrailing) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
ToolbarItem(placement: .topBarTrailing) {
}
ToolbarItem(placement: .topBarTrailing) {

์ค„๋ฐ”๊ฟˆํ•„์š”ํ• ๊ฑฐ๊ฐ™์•„์š”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค

Comment on lines 75 to 78
.clipShape(Circle())
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

navigationViewStyle stack์œผ๋กœ ์„ค์ •ํ•ด์ฃผ์„ธ์š”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋„ต ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค

Comment on lines 4 to 10
struct StudentCellView: View {
var body: some View {
VStack(alignment: .leading) {
SMSIcon(.profile, width: 101, height: 101)
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์‚ญ์ œํ•˜์˜€์Šต๋‹ˆ๋‹ค

Comment on lines 126 to 145

@ViewBuilder
func techStackRow(techStack: [String]) -> some View {
ScrollView(.horizontal, showsIndicators: false) {
LazyHStack {
ForEach(techStack, id: \.self) { text in
Text(text)
.smsFont(.body1, color: .neutral(.n40))
.padding(.horizontal, 12)
.padding(.vertical, 5.5)
.background(
Color.sms(.neutral(.n10))
)
.cornerRadius(8)
}

Spacer()
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Row๋Š” ๋ฐ˜๋ณต๋˜๋Š” View๋ฅผ ๋‚˜์—ดํ•  ๋•Œ ๋‹จ์ผ View๋กœ ์“ฐ๋Š” ์šฉ๋„๊ฐ€ ์ฃผ ์šฉ๋„์ด๋‹ˆ ์ด๋ฆ„์„ ๋ฐ”๊ฟ”๋ณด๋Š”๊ฑฐ ์–ด๋–ค๊ฐ€์š”?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ข‹์€๊ฑฐ ๊ฐ™์Šต๋‹ˆ๋‹ค! ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค

Comment on lines 115 to 116
Text(name)
.smsFont(.title2)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ทธ๋ƒฅ SMSText๋กœ ํ•˜๋Š”๊ฒŒ ์–ด๋–ค๊ฐ€์š”?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ข‹์€๊ฑฐ ๊ฐ™์Šต๋‹ˆ๋‹ค! ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค

Comment on lines 117 to 121

Text(major)
.smsFont(.body2)
.padding(.bottom, 16)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด์ชฝ๋„ ๋งˆ์ฐฌ๊ฐ€์ง€๋กœ ๊ทธ๋ƒฅ SMSText๊ฐ€ ์–ด๋–ค๊ฐ€์š”?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ข‹์€๊ฑฐ ๊ฐ™์Šต๋‹ˆ๋‹ค! ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค

Comment on lines 21 to 30
guard isLast else {
Task {
let studentList = try await fetchStudentListUseCase.execute(req: .init(page: page, size: 20))
model?.appendContent(content: studentList.studentList)
model?.updateTotalSize(totalSize: studentList.totalSize)
model?.updatePage(page: page + 1)
model?.updateIsLast(isLast: studentList.isLast)
}
return
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@Published var isLast: Bool = false
@Published var isError: Bool = false
@Published var content: [SingleStudentEntity] = []
@Published var studentList: PagedStudentListEntity = .init(studentList: [], totalSize: 0, isLast: false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๊ฑฐ ์“ฐ๋Š”๋ฐ๊ฐ€ ์—†๋Š”๋ฐ ์™œ ์žˆ๋Š”๊ฑด๊ฐ€์š”?

Comment on lines 121 to 139
@ViewBuilder
func techStackListView(techStack: [String]) -> some View {
ScrollView(.horizontal, showsIndicators: false) {
LazyHStack {
ForEach(techStack, id: \.self) { text in
Text(text)
.smsFont(.body1, color: .neutral(.n40))
.padding(.horizontal, 12)
.padding(.vertical, 5.5)
.background(
Color.sms(.neutral(.n10))
)
.cornerRadius(8)
}

Spacer()
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?? ๋“ค์—ฌ์“ฐ๊ธฐ ๋ฌด์Šจ์ผ์ด

Comment on lines 43 to 44
Divider()
.background(Color.sms(.neutral(.n10)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๊ฑฐ SMSSeparator ์จ์ฃผ์„ธ์š”

@kimsh153 kimsh153 merged commit 2b0aa03 into master Jun 12, 2023
@kimsh153 kimsh153 deleted the 145-main-page-ui branch June 12, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ - ๊ธด๊ธ‰!!!!! โœจ Feature ์‹ ๊ทœ ๊ธฐ๋Šฅ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

๋ฉ”์ธ ํŽ˜์ด์ง€ UI ์ œ์ž‘
2 participants