Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: ์ •๋ณด์ž…๋ ฅ ์„ธ๋ถ€์Šคํƒ ์ž…๋ ฅ ์—ฐ๊ฒฐ #176

Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ public extension TargetDependency {
}

public extension TargetDependency.SPM {
static let TagLayoutView = TargetDependency.external(name: "TagLayoutView")
static let NukeUI = TargetDependency.external(name: "NukeUI")
static let Needle = TargetDependency.external(name: "NeedleFoundation")
static let GAuthSignin = TargetDependency.external(name: "GAuthSignin")
Expand Down
4 changes: 4 additions & 0 deletions Projects/App/Sources/Application/NeedleGenerated.swift
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,9 @@ private class InputProfileInfoDependencydedc6189ad35e7ff3001Provider: InputProfi
var majorDomainBuildable: any MajorDomainBuildable {
return appComponent.majorDomainBuildable
}
var techStackAppendBuildable: any TechStackAppendBuildable {
return appComponent.techStackAppendBuildable
}
private let appComponent: AppComponent
init(appComponent: AppComponent) {
self.appComponent = appComponent
Expand Down Expand Up @@ -389,6 +392,7 @@ extension StudentDetailComponent: Registration {
extension InputProfileInfoComponent: Registration {
public func registerItems() {
keyPathToName[\InputProfileInfoDependency.majorDomainBuildable] = "majorDomainBuildable-any MajorDomainBuildable"
keyPathToName[\InputProfileInfoDependency.techStackAppendBuildable] = "techStackAppendBuildable-any TechStackAppendBuildable"
}
}
extension FileDomainComponent: Registration {
Expand Down
5 changes: 4 additions & 1 deletion Projects/Core/DesignSystem/Project.swift
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,11 @@ let project = Project.makeModule(
name: ModulePaths.Core.DesignSystem.rawValue,
product: .framework,
targets: [.demo],
externalDependencies: [
.SPM.TagLayoutView
],
internalDependencies: [
.Shared.ViewUtil
.Shared.ViewUtil,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ•„์š”์—†๋Š” ๋ฐ˜์ ์ด ์žˆ๋Š”๊ฑฐ ๊ฐ™์•„์š” ์ง€์›Œ์ฃผ์„ธ์š”

],
resources: ["Resources/**"]
)
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"images" : [
{
"filename" : "XmarkOutline.svg",
"idiom" : "universal"
}
],
"info" : {
"author" : "xcode",
"version" : 1
}
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions Projects/Core/DesignSystem/Sources/Icon/SMSIcon.swift
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ public struct SMSIcon: View {
case smallPlus
case magnifyingglass
case xmark
case xmarkOutline
}

public var body: some View {
Expand Down Expand Up @@ -90,6 +91,9 @@ public struct SMSIcon: View {

case .xmark:
return DesignSystemAsset.Icons.xmark.swiftUIImage

case .xmarkOutline:
return DesignSystemAsset.Icons.xmarkOutline.swiftUIImage
}
}
// swiftlint: enable cyclomatic_complexity
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ extension TechStackEndpoint: SMSEndpoint {
switch self {
case let .fetchTechStackList(keyword):
return .requestParameters(query: [
"name": keyword
"stack": keyword
])

default:
Expand Down
1 change: 1 addition & 0 deletions Projects/Feature/InputProfileInfoFeature/Project.swift
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ let project = Project.makeModule(
targets: [.interface, .unitTest],
internalDependencies: [
.Feature.InputInformationBaseFeature,
.Feature.TechStackAppendFeatureInterface,
.Domain.MajorDomainInterface
],
unitTestDependencies: [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@ import InputProfileInfoFeatureInterface
import MajorDomainInterface
import NeedleFoundation
import SwiftUI
import TechStackAppendFeatureInterface

public protocol InputProfileInfoDependency: Dependency {
var majorDomainBuildable: any MajorDomainBuildable { get }
var techStackAppendBuildable: any TechStackAppendBuildable { get }
}

public final class InputProfileInfoComponent:
Expand All @@ -24,6 +26,9 @@ public final class InputProfileInfoComponent:
model: model as InputProfileInfoStateProtocol,
modelChangePublisher: model.objectWillChange
)
return InputProfileInfoView(container: container)
return InputProfileInfoView(
container: container,
techStackAppendBuildable: dependency.techStackAppendBuildable
)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,16 @@ final class InputProfileInfoIntent: InputProfileInfoIntentProtocol {
model?.updatePortfolioURL(portfolioURL: portfolioURL)
}

func updateTechStack(techStack: String) {
model?.updateTeckStack(techStack: techStack)
func techStackAppendIsRequired() {
model?.updateIsPresentedTeckStackAppend(isPresented: true)
}

func techStackAppendDismissed() {
model?.updateIsPresentedTeckStackAppend(isPresented: false)
}

func techStackAppendDidComplete(techStacks: [String]) {
model?.appendTeckStacks(techStacks: techStacks)
}

func majorSheetIsRequired() {
Expand Down Expand Up @@ -108,9 +116,7 @@ final class InputProfileInfoIntent: InputProfileInfoIntentProtocol {
contactEmail: state.email,
major: state.major,
portfoiloURL: state.portfolioURL,
techStack: state.techStack.components(separatedBy: ",")
.prefix(5)
.map { $0.trimmingCharacters(in: .whitespaces) }
techStack: state.techStacks
)
inputProfileDelegate?.completeToInputProfile(input: input)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ protocol InputProfileInfoIntentProtocol {
func updateEmail(email: String)
func updateMajor(major: String)
func updatePortfolioURL(portfolioURL: String)
func updateTechStack(techStack: String)
func techStackAppendIsRequired()
func techStackAppendDismissed()
func techStackAppendDidComplete(techStacks: [String])
func majorSheetIsRequired()
func majorSheetDismissed()
func imagePickerIsRequired()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,15 @@ final class InputProfileInfoModel: ObservableObject, InputProfileInfoStateProtoc
@Published var major: String = ""
@Published var majorList: [String] = []
@Published var portfolioURL: String = ""
@Published var techStack: String = ""
@Published var techStacks: [String] = []
@Published var isPresentedMajorSheet: Bool = false
@Published var isPresentedImagePicker: Bool = false
@Published var isPresentedImageMethodPicker: Bool = false
@Published var isPresentedCamera: Bool = false
@Published var isSelfEntering: Bool = false
@Published var inputProfileErrorFieldSet: Set<InputProfileErrorField> = []
@Published var profileImage: PickedImageResult?
@Published var isPresentedTechStackAppend: Bool = false
var isDisabledNextButton: Bool {
introduce.isEmpty ||
email.isEmpty ||
Expand Down Expand Up @@ -44,8 +45,12 @@ extension InputProfileInfoModel: InputProfileInfoActionProtocol {
self.portfolioURL = portfolioURL
}

func updateTeckStack(techStack: String) {
self.techStack = techStack
func appendTeckStacks(techStacks: [String]) {
self.techStacks.append(contentsOf: techStacks)
}

func updateIsPresentedTeckStackAppend(isPresented: Bool) {
self.isPresentedTechStackAppend = isPresented
}

func updateIsPresentedMajorSheet(isPresented: Bool) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ protocol InputProfileInfoStateProtocol {
var major: String { get }
var majorList: [String] { get }
var portfolioURL: String { get }
var techStack: String { get }
var techStacks: [String] { get }
var isPresentedMajorSheet: Bool { get }
var isPresentedImagePicker: Bool { get }
var isPresentedImageMethodPicker: Bool { get }
Expand All @@ -24,6 +24,7 @@ protocol InputProfileInfoStateProtocol {
var inputProfileErrorFieldSet: Set<InputProfileErrorField> { get }
var profileImage: PickedImageResult? { get }
var isDisabledNextButton: Bool { get }
var isPresentedTechStackAppend: Bool { get }
}

protocol InputProfileInfoActionProtocol: AnyObject {
Expand All @@ -32,7 +33,8 @@ protocol InputProfileInfoActionProtocol: AnyObject {
func updateMajor(major: String)
func updateMajorList(majorList: [String])
func updatePortfolioURL(portfolioURL: String)
func updateTeckStack(techStack: String)
func appendTeckStacks(techStacks: [String])
func updateIsPresentedTeckStackAppend(isPresented: Bool)
func updateIsPresentedMajorSheet(isPresented: Bool)
func updateIsPresentedImagePicker(isPresented: Bool)
func updateIsPresentedImageMethodPicker(isPresented: Bool)
Expand Down
Loading