Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: 정보 μž…λ ₯ νŽ˜μ΄μ§€μ—μ„œ μž…λ ₯듀에 Validation μ„€μ • #212

Merged
merged 1 commit into from
Jun 18, 2023
Merged

πŸ”€ :: 정보 μž…λ ₯ νŽ˜μ΄μ§€μ—μ„œ μž…λ ₯듀에 Validation μ„€μ • #212

merged 1 commit into from
Jun 18, 2023

Conversation

baekteun
Copy link
Member

πŸ’‘ κ°œμš”

정보 μž…λ ₯을 진행할 λ•Œ μž…λ ₯ ν•„λ“œμ— Validation μ„€μ • 및 곡백 μžλ™ 필터링

@baekteun baekteun added 0️⃣ Priority: Critical μš°μ„ μˆœμœ„ - κΈ΄κΈ‰!!!!! ♻️ Refactor μ½”λ“œ λ¦¬νŒ©ν† λ§ labels Jun 16, 2023
@baekteun baekteun self-assigned this Jun 16, 2023
@baekteun baekteun requested a review from kimsh153 as a code owner June 16, 2023 11:25
@baekteun baekteun linked an issue Jun 16, 2023 that may be closed by this pull request
희망 근무 지역 ν•œμ˜μžλ§Œ μž…λ ₯ν•  수 μžˆλ„λ‘ validation #211
Closed
kimsh153
kimsh153 reviewed Jun 18, 2023
View reviewed changes
Projects/Feature/InputLanguageInfoFeature/Sources/Intent/InputLanguageInfoIntent.swift
Comment on lines +41 to +46
.map {
(
name: $0.languageName.trimmingCharacters(in: .whitespacesAndNewlines),
score: $0.languageScore.trimmingCharacters(in: .whitespacesAndNewlines)
)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ œκ°€ λ³΄κΈ°μ—λŠ” λ³„λ‘œ 쒋은 μŠ€νƒ€μΌμ΄ μ•„λ‹Œκ±° 같은데 λ‹€λ₯Έλ°©μ‹μœΌλ‘œ λ°”κΏ€ 순 μ—†μ„κΉŒμš”? 개인적인 μ£Όκ΄€μž…λ‹ˆλ‹€!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ꡬ쑰체둜 λΊ„κΉŒμš”? ν”„λ‘œνΌν‹° 2개라 νŠœν”Œλ‘œ μ²˜λ¦¬ν•˜κΈ΄ν–ˆμŠ΅λ‹ˆλ‹€

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ꡬ쑰체둜 빼도 많이 쒋아보일거 같지 μ•Šμ•„μ„œ 별 방법이 μ—†μœΌλ©΄ κ·Έλƒ₯ ν•˜μ£ !

@baekteun baekteun merged commit 08c3313 into master Jun 18, 2023
@baekteun baekteun deleted the 211-i-want-to-input-my-hope-region-with-korean branch June 18, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimsh153 kimsh153 kimsh153 approved these changes

Assignees

@baekteun baekteun

Labels
0️⃣ Priority: Critical μš°μ„ μˆœμœ„ - κΈ΄κΈ‰!!!!! ♻️ Refactor μ½”λ“œ λ¦¬νŒ©ν† λ§
Projects
None yet
Milestone
No milestone
2 participants
@baekteun @kimsh153