Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: ๋ฉ”์ธ ํŽ˜์ด์ง€ refresh ๊ธฐ๋Šฅ ์ถ”๊ฐ€ #214

Merged
merged 4 commits into from
Jun 19, 2023

Conversation

kimsh153
Copy link
Member

๐Ÿ’ก ๊ฐœ์š”

๋ฉ”์ธ ํŽ˜์ด์ง€ refresh ๊ธฐ๋Šฅ ์ถ”๊ฐ€

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

๋ฉ”์ธ ํŽ˜์ด์ง€ refresh ๊ธฐ๋Šฅ ์ถ”๊ฐ€

  • Refresh ๋งŒ๋“ฌ!

์งˆ๋ฌธ

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2023-06-17 แ„‹แ…ฉแ„’แ…ฎ 4 10 52

์ด๊ฑฐ ํ†ตํ•ฉ ์–ด๋–ป๊ฒŒ ์‹œํ‚ค๋Š”์ง€ ์•„์‹œ๋‚˜์š”?

@kimsh153 kimsh153 requested a review from baekteun as a code owner June 17, 2023 07:11
@kimsh153 kimsh153 self-assigned this Jun 17, 2023
@kimsh153 kimsh153 added 0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ - ๊ธด๊ธ‰!!!!! โœจ Feature ์‹ ๊ทœ ๊ธฐ๋Šฅ labels Jun 17, 2023
@@ -23,6 +24,8 @@ protocol MainActionProtocol: AnyObject {
func updateIsPresentedLogoutDialog(isPresented: Bool)
func updateIsPresentedWithdrawalDialog(isPresented: Bool)
func appendContent(content: [SingleStudentEntity])
func updateContent(content: [SingleStudentEntity])
func updateRefresh(isRefresh: Bool)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updateIsRefresh๋กœ ํ•˜๋Š”๊ฒŒ ์ข‹์„๊ฑฐ๊ฐ™์•„์š”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋„ต ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค

@@ -64,10 +64,14 @@ struct MainView: View {

Color.clear
.onAppear {
guard !state.isRefresh else { return }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์–ด ์ด๊ฑฐ ์„ฑ๊ณตํ•œ๊ฑด๊ฐ€์š”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋„ค ์ €๊ฑฐ ์•ˆ ํ•˜๋ฉด reachedBottom์ด๋ž‘ ๋™์‹œ์— ์‹คํ–‰๋ฉ๋‹ˆ๋‹ค

@baekteun
Copy link
Member

์งˆ๋ฌธ

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2023-06-17 แ„‹แ…ฉแ„’แ…ฎ 4 10 52 ์ด๊ฑฐ ํ†ตํ•ฉ ์–ด๋–ป๊ฒŒ ์‹œํ‚ค๋Š”์ง€ ์•„์‹œ๋‚˜์š”?

ํ•˜ํ•˜, ์ €๋„ ๋ชจ๋ฆ…๋‹ˆ๋‹ค

@kimsh153
Copy link
Member Author

์งˆ๋ฌธ

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2023-06-17 แ„‹แ…ฉแ„’แ…ฎ 4 10 52 ์ด๊ฑฐ ํ†ตํ•ฉ ์–ด๋–ป๊ฒŒ ์‹œํ‚ค๋Š”์ง€ ์•„์‹œ๋‚˜์š”?

ํ•˜ํ•˜, ์ €๋„ ๋ชจ๋ฆ…๋‹ˆ๋‹ค

ํ•˜ํ•˜ ์•„์‰ฝ๋„ค์š”

@kimsh153 kimsh153 merged commit 8638700 into master Jun 19, 2023
@kimsh153 kimsh153 deleted the 213-main-page-refresh-add branch June 19, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ - ๊ธด๊ธ‰!!!!! โœจ Feature ์‹ ๊ทœ ๊ธฐ๋Šฅ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

๋ฉ”์ธ ํŽ˜์ด์ง€ ๋ฆฌํ”„๋ ˆ์‹œ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
2 participants