Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: [#239] DreamBook ๊ด€๋ จ๋œ ์ฝ”๋“œ ์ง€์šฐ๊ธฐ #240

Merged
merged 2 commits into from
Aug 10, 2023
Merged

๐Ÿ”€ :: [#239] DreamBook ๊ด€๋ จ๋œ ์ฝ”๋“œ ์ง€์šฐ๊ธฐ #240

merged 2 commits into from
Aug 10, 2023

Conversation

kimsh153
Copy link
Member

@kimsh153 kimsh153 commented Aug 4, 2023

๐Ÿ’ก ๊ฐœ์š”

DreamBook ๊ด€๋ จ๋œ ์ฝ”๋“œ ์ง€์šฐ๊ธฐ

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

DreamBook ๊ด€๋ จ๋œ ์ฝ”๋“œ ์ง€์› ์Šต๋‹ˆ๋‹ค

@kimsh153 kimsh153 added 2๏ธโƒฃ Priority: Medium ์šฐ์„ ์ˆœ์œ„ - ์ค‘ โ™ป๏ธ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง ๐Ÿชก Want ํ•ด์ค˜. labels Aug 4, 2023
@kimsh153 kimsh153 self-assigned this Aug 4, 2023
@kimsh153 kimsh153 requested a review from baekteun as a code owner August 4, 2023 08:41
@kimsh153 kimsh153 linked an issue Aug 4, 2023 that may be closed by this pull request
๋“œ๋ฆผ๋ถ ํŒŒ์ผ ์ž…๋ ฅ ์ œ๊ฑฐ #239
Closed
baekteun
baekteun reviewed Aug 4, 2023
View reviewed changes
Projects/Feature/StudentDetailFeature/Sources/Model/StudentDetailModel.swift Outdated
Comment on lines 55 to 57
func updateHWPDocument(hwpDocument: HWPDocument) {
self.hwpDocument = hwpDocument
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hwpDocument๊ด€๋ จ ํŒŒ์ผ๋„ ์ฃฝ์—ฌ์ฃผ์„ธ์šฉ

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋„ต ์ง€์› ์Šต๋‹ˆ๋‹ค 612683d (#240)

@kimsh153 kimsh153 merged commit 63d8ac9 into master Aug 10, 2023
@kimsh153 kimsh153 deleted the 239-input-dreambook-file-delete branch August 10, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baekteun baekteun baekteun approved these changes

Assignees

@kimsh153 kimsh153

Labels
2๏ธโƒฃ Priority: Medium ์šฐ์„ ์ˆœ์œ„ - ์ค‘ โ™ป๏ธ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง ๐Ÿชก Want ํ•ด์ค˜.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

๋“œ๋ฆผ๋ถ ํŒŒ์ผ ์ž…๋ ฅ ์ œ๊ฑฐ
2 participants
@kimsh153 @baekteun