Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: ๋””ํ…Œ์ผ ํŽ˜์ด์ง€ ์ˆ˜์ • #250

Merged
merged 14 commits into from
Aug 24, 2023

Conversation

kimsh153
Copy link
Member

@kimsh153 kimsh153 commented Aug 24, 2023

๐Ÿ’ก ๊ฐœ์š”

๋””ํ…Œ์ผ ํŽ˜์ด์ง€ ์ˆ˜์ •

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • ConditionView๋ฅผ ์‚ฌ์šฉํ•ด์„œ ๋ณด์ด์ง€ ์•Š์•„์•ผํ•  ๊ธ€์ž์™€ ๊ฐ„๊ฒฉ ์ˆ˜์ •
  • ์ž„์‹œ๋กœ ๋กœ๊ทธ์•„์›ƒ ์—‘์„ธ์Šคํ† ํฐ ๋„ฃ์–ด์ฃผ๊ธฐ
  • TechStacks๋กœ ๋ณ€๊ฒฝ

@kimsh153 kimsh153 added 1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ - ์ƒ โ™ป๏ธ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง โœจ Feature ์‹ ๊ทœ ๊ธฐ๋Šฅ labels Aug 24, 2023
@kimsh153 kimsh153 self-assigned this Aug 24, 2023
@kimsh153 kimsh153 requested a review from baekteun as a code owner August 24, 2023 02:48
@@ -88,7 +88,7 @@ struct TechStackAppendView: View {
SMSChip("\"\(state.searchText)\" ์ง์ ‘ ์ถ”๊ฐ€ํ•˜๊ธฐ") {
intent.directAppendButtonDidTap(techStack: state.searchText)
}
.conditional(!state.selectedTechStacks.contains(state.searchText) && !state.searchText.isEmpty)
.conditional(!state.selectedTechStacks.contains(state.searchText) && state.searchText.isNotEmpty)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๊ฑฐ๋„ notContains ๋งŒ๋“œ๋Š”๊ฑฐ ์–ด๋•Œ์š”?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ•ด๋‹น ์‚ฌํ•ญ์€ ํ˜„์žฌ ๋ธŒ๋žœ์น˜์—์„œ ์ง„ํ–‰ํ•˜๋Š”๊ฒƒ๋ณด๋‹ค ์ƒˆ๋กœ ์ด์Šˆ๋ฅผ ์ƒ์„ฑํ•ด์„œ ํ•˜๋Š”๊ฒƒ์ด ์ข‹์•„๋ณด์ž…๋‹ˆ๋‹ค.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๋Ÿฐ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด์Šˆ ํŒŒ๋†“์•„์ฃผ์„ธ์š”

Copy link
Member

@baekteun baekteun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dms-logo

@kimsh153 kimsh153 merged commit 74461b8 into master Aug 24, 2023
@kimsh153 kimsh153 deleted the 243-modify-detail-prize-project-ui branch August 24, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ - ์ƒ โœจ Feature ์‹ ๊ทœ ๊ธฐ๋Šฅ โ™ป๏ธ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง
Projects
None yet
2 participants