Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: Signin νŽ˜μ΄μ§€ μ œμž‘ #27

Merged
merged 42 commits into from
May 1, 2023
Merged

πŸ”€ :: Signin νŽ˜μ΄μ§€ μ œμž‘ #27

merged 42 commits into from
May 1, 2023

Conversation

kimsh153
Copy link
Member

πŸ’‘ κ°œμš”

Signin νŽ˜μ΄μ§€ μ œμž‘

πŸ“ƒ μž‘μ—…λ‚΄μš©

Signin νŽ˜μ΄μ§€ μ œμž‘, SMSImage

πŸ”€ 변경사항

  • SMSImage μΆ”κ°€
  • SigninFeature framework ν™”
  • Signin API 연동
  • Signin UI

🎸 기타

싀행해보고 였λ₯˜ λ‚˜λŠ”μ§€ μ²΄ν¬ν•΄μ£Όμ„Έμš”

kimsh153 added 28 commits April 23, 2023 22:28
@kimsh153
✨ Add SiginFeature
3a8337b
@kimsh153
✏️ Dotori -> SMS
0021dd1
@kimsh153
πŸ”§ SiginFactory 생성
5fd838a
@kimsh153
πŸ“¦ GAuthSignin μΆ”κ°€
5d218df
@kimsh153
πŸ“¦ Needle 생성
8ea1173
@kimsh153
🏷️ intent, model public으둜 λ³€κ²½
7cbf02f
@kimsh153
🚧 μž„μ‹œ 컀밋
0f30773
@kimsh153
πŸ”¨ NeedleRunScript μΆ”κ°€
8c8ab5b
@kimsh153
πŸ“¦ Needle μΆ”κ°€
55d86e1
@kimsh153
✨ KeychainComponent
ded375a
@kimsh153
✨ KeychainComponentProtocol 생성
613dbb9
@kimsh153
πŸ”₯ NeedleModule μ‚­μ œ
644a364
@kimsh153
βž• JwtStoreComponent
32b1217
@kimsh153
✨ SwiftLint.yml
00bca12
@kimsh153
βž• AuthDomainComponentProtocol 생성
b96e5b0
@kimsh153
βž• AuthDomainComponent 생성
bc27fb7
@kimsh153
πŸ”₯ Needle 방식 λ°”κΎΈλ©΄μ„œ ν•„μš”ν•˜μ§€ μ•Šμ€ μ½”λ“œ μ§€μš°κΈ°
effee81
@kimsh153
✨ SMSApp SigninComponent μ—°κ²°
c83eb06
@kimsh153
βž• μ˜μ‘΄μ„± μ£Όμž…
bc794db
@kimsh153
βž• SigninComponent
3290e15
@kimsh153
βž• SigninDependency μΆ”κ°€
8a5e0bd
@kimsh153
🍱 DesignSystem Background Image μΆ”κ°€
203896c
@kimsh153
πŸ“± SMSImage μ œμž‘
c12aace
@kimsh153
πŸ”₯ μ•ˆμ“°λŠ” μ½”λ“œ μ§€μš°κΈ°
a563068
@kimsh153
πŸ”’ XCConfig μ„€μ •
aed66c1
@kimsh153
⚰️ AppDelegate
bf54ba9
@kimsh153
πŸ’„ SigninUI
70c4398
@kimsh153
Merge branch 'master' of https://github.com/GSM-MSG/SMS-iOS into 23-f…
2f044c2 
…eat-signin-page
@kimsh153 kimsh153 added 0️⃣ Priority: Critical μš°μ„ μˆœμœ„ - κΈ΄κΈ‰!!!!! βš™ Setting ν™˜κ²½ μ„ΈνŒ… labels Apr 30, 2023
@kimsh153 kimsh153 added the ✨ Feature μ‹ κ·œ κΈ°λŠ₯ label Apr 30, 2023
@kimsh153 kimsh153 requested a review from baekteun April 30, 2023 13:23
@kimsh153 kimsh153 self-assigned this Apr 30, 2023
@kimsh153 kimsh153 linked an issue Apr 30, 2023 that may be closed by this pull request
둜그인 νŽ˜μ΄μ§€ μ œμž‘ #23
Closed
baekteun
baekteun reviewed Apr 30, 2023
View reviewed changes
Projects/App/Sources/Application/DI/AppComponent.swift Outdated Show resolved Hide resolved
Projects/App/Sources/Application/DI/AppComponent.swift Outdated Show resolved Hide resolved
Projects/Core/DesignSystem/Sources/Image/SMSImage.swift Outdated Show resolved Hide resolved
Projects/Core/JwtStore/Interface/DI/JwtStoreComponentProtocol.swift Outdated Show resolved Hide resolved
Projects/Core/JwtStore/Sources/DI/JwtStoreComponent.swift Outdated Show resolved Hide resolved
Projects/Feature/SigninFeature/Sources/Scene/CodeDidRecived.swift Outdated Show resolved Hide resolved
Projects/Feature/SigninFeature/Sources/Scene/SigninView.swift Show resolved Hide resolved
Projects/Feature/SigninFeature/Sources/Scene/SigninView.swift Outdated Show resolved Hide resolved
Projects/Feature/SigninFeature/Sources/Scene/SigninView.swift Outdated Show resolved Hide resolved
Projects/Feature/SigninFeature/Sources/Scene/CodeDidRecived.swift Outdated Show resolved Hide resolved
kimsh153 and others added 9 commits April 30, 2023 22:38
@kimsh153 @baekteun
Update Projects/Core/JwtStore/Interface/DI/JwtStoreComponentProtocol.…
0f23e29 
…swift

Co-authored-by: baegteun <baegteun@gmail.com>
@kimsh153 @baekteun
Update Projects/Core/JwtStore/Sources/DI/JwtStoreComponent.swift
b2c3eb8 
Co-authored-by: baegteun <baegteun@gmail.com>
@baekteun
Update Projects/Feature/SigninFeature/Sources/Scene/SigninView.swift
4be99bb
@kimsh153 @baekteun
Update Projects/Domain/AuthDomain/Project.swift
04564ff 
Co-authored-by: baegteun <baegteun@gmail.com>
@kimsh153 @baekteun
Update Projects/Domain/AuthDomain/Sources/DI/AuthDomainComponent.swift
eb4ac6a 
Co-authored-by: baegteun <baegteun@gmail.com>
@kimsh153 @baekteun
Update Projects/Feature/BaseFeature/Project.swift
7a6e5c7 
Co-authored-by: baegteun <baegteun@gmail.com>
@kimsh153 @baekteun
Update Projects/Feature/SigninFeature/Sources/Intent/SigninIntent.swift
252bcd5 
Co-authored-by: baegteun <baegteun@gmail.com>
@kimsh153
♻️ Comment μˆ˜μ •
912ba5e
@kimsh153
♻️ Comment μˆ˜μ •
de8eb41
@kimsh153 @baekteun
Update Projects/Feature/SigninFeature/Project.swift
17739d6 
Co-authored-by: baegteun <baegteun@gmail.com>
@kimsh153 @baekteun
Update Projects/Feature/SigninFeature/Project.swift
e0de8da 
Co-authored-by: baegteun <baegteun@gmail.com>
@kimsh153 kimsh153 merged commit b861acc into master May 1, 2023
@kimsh153 kimsh153 deleted the 23-feat-signin-page branch May 1, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baekteun baekteun baekteun approved these changes

Assignees

@kimsh153 kimsh153

Labels
0️⃣ Priority: Critical μš°μ„ μˆœμœ„ - κΈ΄κΈ‰!!!!! ✨ Feature μ‹ κ·œ κΈ°λŠ₯ βš™ Setting ν™˜κ²½ μ„ΈνŒ…
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

둜그인 νŽ˜μ΄μ§€ μ œμž‘
2 participants
@kimsh153 @baekteun