๐ :: [#339] ํฌํธํด๋ฆฌ์ค ๊ณต์ ๋ค์ด์ผ๋ก๊ทธ ์ถ๊ฐ #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uuuunseo
added
1๏ธโฃ Priority: High
uuuunseo
requested review from
shwaaaa,
hanjaehyeong and
kimkyumbi
as code owners
baekteun
reviewed
Jun 4, 2024
| import SwiftUI | ||
| import DesignSystem | ||
|
|
||
| struct SelectedEffectiveDateView<T, ID, Content>: View where ID: Hashable, Content: View { |
There was a problem hiding this comment.
SelectedEffectiveDateView๋ ์ ํ๋์ด ์์ ๋ถ์ด์ ์ ํ๋ ์ํ์ View์ธ๊ฐ๋ก ์๊ฐ๋ ์๋ ์์๊ฑฐ๊ฐ์๋ฐ EffectiveDateRadioGroupView ? ์ด๋ฐ์ ์ด๋ค๊ฐ์
There was a problem hiding this comment.
์ค!! ์ฒ์์ EffectiveDateRadioCell ๊ฐ์ ๊ฒ๋ ์๊ฐํด ๋ดค์๋๋ฐ FilterFeature์ RadioCell์ด ์์ด์ ์ด ์ด๋ฆ์ผ๋ก ํ๋๋ฐ ์๊ฐํด๋ณด๋ ์ ํ๋ ์ํ๋ผ๊ณ ์๊ฐ๋ ๊ฑฐ ๊ฐ์์. EffectiveDateRadioGroupView๋ก ๋ณ๊ฒฝํ ๊ฒ์!!
There was a problem hiding this comment.
๋ณ๊ฒฝํ์ต๋๋ค!!
uuuunseo
force-pushed
the
339-portfolio-link-dialog
branch
from
8d8b7c7 to
97f391a
Compare
shwaaaa
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐ์
๊ธฐ์ ๋ด๋น์๋ถ๋ค์ด ํ์ ๊ฐ์ธ์ ํฌํธํด๋ฆฌ์ค๋ฅผ ์ด๋ํ๊ธฐ ์ํด ๋งํฌ๋ฅผ ์์ฑํด์ผํ๋ ์๊ตฌ์ฌํญ์ด ์๊ฒผ์ด์.
Resolves: #339
๐ ์์ ๋ด์ฉ
Simulator.Screen.Recording.-.iPhone.15.-.2024-06-04.at.11.40.36.mp4
โ PR ์ฒดํฌ๋ฆฌ์คํธ
.env,๋ ธ์ ,README)"API ๊ฐ๋ฐ ์๋ฃ๋์ด์","ํ๊ฒฝ๊ฐ ์ถ๊ฐ๋์์ด์")