Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”€ :: [#345] 인증제 νŽ˜μ΄μ§€ μ œμž‘ #342

Conversation

kimsh153
Copy link
Member

@kimsh153 kimsh153 commented Jun 15, 2024

πŸ’‘ λ°°κ²½ 및 κ°œμš”

인증제 νŽ˜μ΄μ§€ μ œμž‘ν–ˆμŠ΅λ‹ˆλ‹€

Resolves: #345

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • 인증제 νŽ˜μ΄μ§€ μ œμž‘
  • 파일 μ—…λ‘œλ“œ μ œμž‘

βœ… PR 체크리슀트

ν…œν”Œλ¦Ώ 체크리슀트 말고도 μΆ”κ°€μ μœΌλ‘œ ν•„μš”ν•œ μ²΄ν¬λ¦¬μŠ€νŠΈλŠ” μΆ”κ°€ν•΄μ£Όμ„Έμš”!

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. .env, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "ν™˜κ²½κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@kimsh153 kimsh153 force-pushed the 342-authentication-form-fetch-api branch from 8a52188 to 4b63a94 Compare June 15, 2024 15:13
흑흑 νž˜λ“€μ–΄μš”
@kimsh153 kimsh153 force-pushed the 342-authentication-form-fetch-api branch from 58a68e1 to 9ae3a2b Compare July 4, 2024 16:28
@kimsh153 kimsh153 force-pushed the 342-authentication-form-fetch-api branch from 3cf7aa0 to a30a2e7 Compare July 9, 2024 13:43
@kimsh153 kimsh153 force-pushed the 342-authentication-form-fetch-api branch from 018baa9 to 4a733aa Compare July 9, 2024 14:43
@kimsh153 kimsh153 force-pushed the 342-authentication-form-fetch-api branch from 6d8115b to 5a0033e Compare July 11, 2024 13:20
@kimsh153 kimsh153 changed the title 🚧 :: wip πŸ”€ :: 인증제 νŽ˜μ΄μ§€ μ œμž‘ Jul 11, 2024
@kimsh153 kimsh153 self-assigned this Jul 11, 2024
@kimsh153 kimsh153 linked an issue Jul 11, 2024 that may be closed by this pull request
@kimsh153 kimsh153 marked this pull request as ready for review July 11, 2024 13:27
@kimsh153 kimsh153 requested a review from baekteun July 11, 2024 13:28
}

// MARK: - Object
public struct Object: Encodable {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Object λ„ˆλ¬΄ λ²”μš©μ μΈ 이름이라 μ’€ 그런데 κ·Έλƒ₯ Nested둜 ν•˜λŠ”κ±° μ–΄λ–€κ°€μš”

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ—„ Authentication 만 있으면 사싀 authμ΄λž‘ κ²Ήμ³λ²„λ¦¬λŠ”μ§€λΌ GSMAuthentication 읍읍

var contents = [Content]()

// 끄어어어얡
for area in model.areas {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μš”κ±° κ·Έλƒ₯ map으둜 돌리면 μ•ˆλ˜λŠ” κ±°λ €λ‚˜μš”

@kimsh153 kimsh153 changed the title πŸ”€ :: 인증제 νŽ˜μ΄μ§€ μ œμž‘ πŸ”€ :: [345] 인증제 νŽ˜μ΄μ§€ μ œμž‘ Jul 11, 2024
@kimsh153 kimsh153 merged commit bcfb79e into 334-authentication-form-ui-building-plus-file-download Jul 11, 2024
2 checks passed
@kimsh153 kimsh153 deleted the 342-authentication-form-fetch-api branch July 11, 2024 13:30
@kimsh153 kimsh153 changed the title πŸ”€ :: [345] 인증제 νŽ˜μ΄μ§€ μ œμž‘ πŸ”€ :: [#345] 인증제 νŽ˜μ΄μ§€ μ œμž‘ Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

인증제 νŽ˜μ΄μ§€ μ œμž‘
2 participants