Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”€ :: DesignSystem SMSDialog μ œμž‘ #38

Merged
merged 9 commits into from
May 30, 2023

Conversation

kimsh153
Copy link
Member

@kimsh153 kimsh153 commented May 9, 2023

πŸ’‘ κ°œμš”

DesignSystem SMSDialog μ œμž‘

πŸ“ƒ μž‘μ—…λ‚΄μš©

DesignSystem SMSDialog μ œμž‘

image

@kimsh153 kimsh153 added 1️⃣ Priority: High μš°μ„ μˆœμœ„ - 상 βš™ Setting ν™˜κ²½ μ„ΈνŒ… labels May 9, 2023
@kimsh153 kimsh153 requested a review from baekteun May 9, 2023 11:11
@kimsh153 kimsh153 self-assigned this May 9, 2023
@kimsh153 kimsh153 linked an issue May 9, 2023 that may be closed by this pull request
@baekteun
Copy link
Member

baekteun commented May 9, 2023

화면에 λ„μš°λŠ” modifier도 λ§Œλ“€μ–΄μ£Όμ„Έμš”

@kimsh153
Copy link
Member Author

화면에 λ„μš°λŠ” modifier도 λ§Œλ“€μ–΄μ£Όμ„Έμš”

λ§Œλ“€μ—ˆμŠ΅λ‹ˆλ‹Ή

Comment on lines 42 to 44
checkAction: @escaping () -> Void = {},
cancelAction: @escaping () -> Void = {},
isShowing: Binding<Bool>
Copy link
Member

@baekteun baekteun May 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BInding이 closure보닀 μ•žμ— 였게 ν•˜λŠ”κ±° μ–΄λ–€κ°€μš”? trailingClosure의 νŠΉμ§•λ•Œλ¬Έμ— closureλ₯Ό λ’€μͺ½μ— λ‘λŠ”κ²Œ μ’‹μ„κ±°κ°™μ•„μš”

Comment on lines 13 to 25
text: String = "",
style: CTAButton.CTAStyle = .default,
action: @escaping () -> Void = { }
) {
self.text = text
self.style = style
self.action = action
}

let id: String = UUID().uuidString
let text: String?
let style: CTAButton.CTAStyle?
let action: (() -> Void)?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν”„λ‘œνΌν‹°κ°€ μ™œ μ˜΅μ…”λ„μΈκ°€μš”?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ—„ μˆ˜μ •ν•˜μ˜€μŠ΅λ‹ˆλ‹€

Comment on lines 12 to 25
public init(
text: String = "",
style: CTAButton.CTAStyle = .default,
action: @escaping () -> Void = { }
) {
self.text = text
self.style = style
self.action = action
}

let id: String = UUID().uuidString
let text: String?
let style: CTAButton.CTAStyle?
let action: (() -> Void)?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initμ΄λž‘ ν”„λ‘œνΌν‹° μˆœμ„œλ„ λ°”κΏ”μ•Όν• κ±°κ°™μ•„μš”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜μ •ν•˜μ˜€μŠ΅λ‹ˆλ‹€

Comment on lines 8 to 9
alertAction: [SMSAlertButtonType],
isShowing: Binding<Bool>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isShowingμ΄λž‘ alertActionμ΄λž‘ νŒŒλΌλ―Έν„° μˆœμ„œ λ°”κΎΈλŠ”κ±° μ–΄λ–€κ°€μš”? action은 λ°°μ—΄λ‘œ μ—¬λŸΏ 받을 수 μžˆμœΌλ‹ˆ 뒀에 μžˆλŠ”κ²Œ λ‚˜μ•„λ³΄μ˜€μŠ΅λ‹ˆλ‹€

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜μ •ν•˜μ˜€μŠ΅λ‹ˆλ‹€

func smsAlert(
title: String,
description: String,
alertAction: [SMSAlertButtonType],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arrayλ‹ˆ alertActions둜 볡수 μ§€μΉ­ν•˜λŠ”κ±° μ–΄λ–€κ°€μš”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜μ •ν•˜μ˜€μŠ΅λ‹ˆλ‹Ή

Comment on lines +50 to +51
.padding(40)
.transition(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν•œ 쀄 μ€„λ°”κΏˆ ν•˜λŠ”κ²Œ μŠ€νƒ€μΌ κ°€μ΄λ“œμ— λ§žμ„κ±°κ°™μ•„μ—¬

Comment on lines 3 to 10
public struct SMSAlertButtonType: Hashable {
public static func == (lhs: SMSAlertButtonType, rhs: SMSAlertButtonType) -> Bool {
lhs.id == rhs.id
}

public func hash(into hasher: inout Hasher) {
hasher.combine(id)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 친ꡬ ForEachμ—μ„œ μ‚¬μš©ν•˜κΈ° μœ„ν•΄μ„œ Hashable μ€€μˆ˜ν•˜λ„λ‘ ν•œκ±΄κ°€μš”?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ§Œμ•½ κ·Έλ ‡λ‹€λ©΄ Identifiableλ₯Ό μ€€μˆ˜ν•˜λ„λ‘ ν•˜λŠ”κ²Œ μ–΄λ–€κ°€μš”?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜μ •ν•˜μ˜€μŠ΅λ‹ˆλ‹€

Co-authored-by: baegteun <baegteun@gmail.com>
@kimsh153 kimsh153 merged commit 2945ee0 into master May 30, 2023
@kimsh153 kimsh153 deleted the 35-dialog-design-system branch May 30, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1️⃣ Priority: High μš°μ„ μˆœμœ„ - 상 βš™ Setting ν™˜κ²½ μ„ΈνŒ…
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DesignSystem Dialog μ œμž‘
2 participants