Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: ๋กœ๊ทธ์ธ์—์„œ ํ•™์ƒ ์ •๋ณด๋ฅผ ๊ธฐ์ž…ํ•œ ํ•™์ƒ์ธ์ง€ ์•„๋‹Œ์ง€์— ๋Œ€ํ•œ ์ •๋ณด #91

Merged
merged 2 commits into from
May 22, 2023
Merged

๐Ÿ”€ :: ๋กœ๊ทธ์ธ์—์„œ ํ•™์ƒ ์ •๋ณด๋ฅผ ๊ธฐ์ž…ํ•œ ํ•™์ƒ์ธ์ง€ ์•„๋‹Œ์ง€์— ๋Œ€ํ•œ ์ •๋ณด #91

merged 2 commits into from
May 22, 2023

Conversation

baekteun
Copy link
Member

๐Ÿ’ก ๊ฐœ์š”

๋กœ๊ทธ์ธAPI์—์„œ ํ•™์ƒ ์ •๋ณด๋ฅผ ๊ธฐ์ž…ํ•œ ํ•™์ƒ์ธ์ง€ ์•„๋‹Œ์ง€์— ๋Œ€ํ•œ ์ •๋ณด๋ฅผ ์ถ”๊ฐ€์ ์œผ๋กœ ๋ฐ›์Šต๋‹ˆ๋‹ค

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • Signin ๋ถ€๋ถ„์—์„œ Bool๊ฐ’์„ ๋ฐ›์•„ ํŒ๋ณ„
  • IsAlreadySignup typealias๋ฅผ ๋งŒ๋“ค์–ด Bool์„ ๋Œ€์‹ ํ•ด ํ‘œํ˜„

๐Ÿ”€ ๋ณ€๊ฒฝ์‚ฌํ•ญ

  • Signin UseCase, Repository, DataSource์— ๋ฆฌํ„ด ํƒ€์ž… 'IsAlreadySignup' ์ถ”๊ฐ€

๐Ÿ™‹โ€โ™‚๏ธ ์งˆ๋ฌธ์‚ฌํ•ญ

  • typealias๋ฅผ ์‚ฌ์šฉํ–ˆ๋Š”๋ฐ ๊ดœ์ฐฎ์„๊นŒ์š”..?

@baekteun baekteun added 1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ - ์ƒ โšก๏ธ Simple ๊ฐ„๋‹จํ•œ ๋ณ€๊ฒฝ์‚ฌํ•ญ labels May 22, 2023
@baekteun baekteun self-assigned this May 22, 2023
@baekteun baekteun requested a review from kimsh153 as a code owner May 22, 2023 01:15
@baekteun baekteun linked an issue May 22, 2023 that may be closed by this pull request
๋กœ๊ทธ์ธ์—์„œ ์ตœ์ดˆ์ธ์ง€ ์•„๋‹Œ์ง€ ํ™•์ธํ•˜๋Š” ๊ฐ’ ๋ฐ›๊ธฐ #84
Closed
@baekteun
Copy link
Member Author

Entity๋กœ ๋งŒ๋“ค๊ธฐ์—” ์ •๋ณด๊ฐ€ Bool ํ•˜๋‚˜๋งŒ ๋ฐ›๊ธฐ์— typealias์—์„œ ํ‘œํ˜„ํ•  ์ˆ˜ ์žˆ๋„๋ก ํ–ˆ๋Š”๋ฐ ์–ด๋–ป๊ฒŒ ์ƒ๊ฐํ•˜์‹œ๋‚˜์š”? @kimsh153

@kimsh153
Copy link
Member

Entity๋กœ ๋งŒ๋“ค๊ธฐ์—” ์ •๋ณด๊ฐ€ Bool ํ•˜๋‚˜๋งŒ ๋ฐ›๊ธฐ์— typealias์—์„œ ํ‘œํ˜„ํ•  ์ˆ˜ ์žˆ๋„๋ก ํ–ˆ๋Š”๋ฐ ์–ด๋–ป๊ฒŒ ์ƒ๊ฐํ•˜์‹œ๋‚˜์š”?

๋ณด๊ธฐ์—๋„ ํŽธํ•˜๊ณ  ์ข‹์€๊ฑฐ ๊ฐ™์Šต๋‹ˆ๋‹ค.

@baekteun baekteun merged commit ee7acb5 into master May 22, 2023
@baekteun baekteun deleted the 84-is-signed-up-user-info-response-in-signin branch May 22, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimsh153 kimsh153 kimsh153 approved these changes

Assignees

@baekteun baekteun

Labels
1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ - ์ƒ โšก๏ธ Simple ๊ฐ„๋‹จํ•œ ๋ณ€๊ฒฝ์‚ฌํ•ญ
Projects
None yet
Milestone
No milestone
2 participants
@baekteun @kimsh153