Plane bug #382
Merged
Plane bug #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3ssy
approved these changes
Mar 8, 2022
d3ssy
added
minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR fixes the bug that was present in one of the Plane's constructors which took in a point and two direction vectors. The constructor now computes the orthogonal vectors which would define the X-axis and the Y-axis of the plane considering the first input direction to be the X-axis.
Although there were already three test cases that that referenced this constructor, another test case is added which is dedicated for this particular constructor.
Related Tickets & Documents
This PR Fixes #377
Added tests?
Added to documentation?