-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the index.md #395
Updated the index.md #395
Conversation
Updated the index.md file for the documentation
Can we have the logo on the index page? |
I don’t think that this is worth a release. We have to find a mechanism to release only on version tags, or we have to split the documentation on a separate branch, potentially a separate repository.
Sent from Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Mirco Bianchini ***@***.***>
Sent: Wednesday, January 4, 2023 10:15:06 AM
To: GSharker/G-Shark ***@***.***>
Cc: Cesare Caoduro ***@***.***>; Assign ***@***.***>
Subject: Re: [GSharker/G-Shark] Updated the index.md (PR #395)
Can we have the logo on the index page?
How do we want to treat these kinds of changes in terms of release/NuGet package?
Currently, if we merge this PR a new NuGet will be generated, is it worth having a new package for changes like this?
—
Reply to this email directly, view it on GitHub<#395 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGJG6AYE5NHV4JPELZBB523WQSXHVANCNFSM6AAAAAATQFD6XM>.
You are receiving this because you were assigned.Message ID: ***@***.***>
|
The release action generates the tag. |
We have to put some more thoughts around this. For now we can merge this small update. |
Weren't the docs being generated from gshark/docs branch? I don't think users should have to touch the doc generation or need to download it with the main branch. |
That is the brunch used to publish the doc, but the documentation is on the main repo, but I don't think is a problem. |
Updated the index.md file for the documentation
What type of PR is this? (check all applicable)
Description
This PR updates the index.md file generated with the documentation
Related Tickets & Documents
No issues related
Added tests?
Added to documentation?