Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the index.md #395

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Updated the index.md #395

merged 1 commit into from
Jan 4, 2023

Conversation

cesarecaoduro
Copy link
Collaborator

Updated the index.md file for the documentation

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

This PR updates the index.md file generated with the documentation

Related Tickets & Documents

No issues related

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📓 docs
  • 🙅 no documentation needed

Updated the index.md file for the documentation
@cesarecaoduro cesarecaoduro added the documentation 📖 Pull requests or issues to add or modify documentation. label Jan 3, 2023
@sonomirco sonomirco added the patch Pull requests requiring a patch version update according to semantic versioning. label Jan 3, 2023
@sonomirco
Copy link
Collaborator

Can we have the logo on the index page?
How do we want to treat these kinds of changes in terms of release/NuGet package?
Currently, if we merge this PR a new NuGet will be generated, is it worth having a new package for changes like this?

@cesarecaoduro
Copy link
Collaborator Author

cesarecaoduro commented Jan 3, 2023 via email

@sonomirco
Copy link
Collaborator

The release action generates the tag.
An implementation is that only PRs with labels Major or Minor creates a NuGet package; all the others add a new release in GitHub.

@cesarecaoduro cesarecaoduro merged commit 94f4f73 into master Jan 4, 2023
@cesarecaoduro cesarecaoduro deleted the dev/ceca/update-docs-home branch January 4, 2023 02:03
@cesarecaoduro
Copy link
Collaborator Author

The release action generates the tag. An implementation is that only PRs with labels Major or Minor creates a NuGet package; all the others add a new release in GitHub.

We have to put some more thoughts around this. For now we can merge this small update.
Also considering the logo, we already have the logo on the sidebar, I don't think there is a need of another logo in the main content.
We probably need to also spend some time styling the template, but it is not a priority (I will Open an issue for this)

@d3ssy
Copy link
Collaborator

d3ssy commented Jan 4, 2023

Weren't the docs being generated from gshark/docs branch? I don't think users should have to touch the doc generation or need to download it with the main branch.

@sonomirco
Copy link
Collaborator

That is the brunch used to publish the doc, but the documentation is on the main repo, but I don't think is a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📖 Pull requests or issues to add or modify documentation. patch Pull requests requiring a patch version update according to semantic versioning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants