compat with ModernKeybinding #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be forked/merged in as well |
|
@Caedis what I need to do? Only add the mod? Add the mod as dep to this code change? |
|
Client only mod |
|
So just add this together with the mod ? |
|
I am probably going to merge ModernKeybindings into this repo in another PR. |
|
Ok. I remember you can set in the run script that it is a client only mod to pass/avoid server test |
|
This is a different issue. Having issues running the mod in java 8 |
OneEyeMaker
reviewed
Aug 19, 2024
src/main/java/com/blamejared/controlling/client/gui/GuiNewControls.java
Outdated
Show resolved
Hide resolved
OneEyeMaker
reviewed
Aug 21, 2024
src/main/java/com/blamejared/controlling/client/gui/GuiNewKeyBindingList.java
Show resolved
Hide resolved
OneEyeMaker
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate the changes from https://github.com/MikhailTapio/ModernControlling/tree/Forge/1.7.10