Rename MTE pipes to be more descriptive & cleanup bounding box #3983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MTEItem -> MTEItemPipe MTEFluid -> MTEFluidPipe GTPPMTEFluid -> GTPPMTEFluidPipe MTEPipeEnergy -> MTEPipeLaser MTEPipeBlockEnergy -> MTEPipeBlockLaser MTEPipeEnergyMirror -> MTEPipeLaserMirror
Caedis
added
the
refactor
|
Have you tested this in the full pack, along with the other prs that have been merged into the dev branch? |
|
Good catch, confirmed working with the pack. Why some item pipes are declared in coremod :fail: |
Dream-Master
added
the
🚧 Testing on Zeta
miozune
changed the title
YannickMG
reviewed
Feb 26, 2025
YannickMG
approved these changes
Feb 27, 2025
Dream-Master
removed
the
🚧 Testing on Zeta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were used to be named
GT_MetaPipeEntity_Itemetc., but lost notation of pipe along with the great renaming.MTEItem -> MTEItemPipe
MTEFluid -> MTEFluidPipe
GTPPMTEFluid -> GTPPMTEFluidPipe
These having "energy" can be confusing. Renamed to "laser" to reflect in-game names.
MTEPipeEnergy -> MTEPipeLaser
MTEPipeBlockEnergy -> MTEPipeBlockLaser
MTEPipeEnergyMirror -> MTEPipeLaserMirror