Localization of fluid chemical formula tooltips in NEI overlay #3989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discreater
force-pushed
the
localization-nei-fluid-formula
branch
from
146868d to
6a02a39
Compare
Dream-Master
added
the
enhancement
serenibyss
reviewed
Feb 24, 2025
Discreater
force-pushed
the
localization-nei-fluid-formula
branch
from
2be5a13 to
1ed0383
Compare
serenibyss
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although in most cases, chemical formulas do not need to be translated, we must consider the understanding difficulties for non-native English speakers when a chemical formula has become a phrase or a sentence (such as "THE END" / "THE FUTURE"). Moreover, except for the fluid tooltips in the NEI coverage layer, chemical formulas in other areas can already be localized.
There might be beter ways to modify the code, but the current changes are indeed effective.
Before
After
