Restore MTEHatchEnergy inventory size + description constructor

[serenibyss]

Needed for an addon here: https://github.com/Nxer/Twist-Space-Technology-Mod/blob/main/src/main/java/com/Nxer/TwistSpaceTechnology/common/machine/singleBlock/hatch/GT_Hatch_BufferedEnergyHatch.java

Was removed in #3961

[boubou19]

Can't twist update its code to use other constructors? GT5U is NH only, so if it has no use in NH...

[serenibyss]

Can't twist update its code to use other constructors? GT5U is NH only, so if it has no use in NH...

It can't, the PR removing this constructor removed the only way for energy hatches to set their inventory size, and since it is passed up to set a final array (not wrapped with a getter), I'm not aware of any way to do this even with reflection since afaik on newer java VMs, using things to modify a final field with reflection doesn't work well. So the only option would be mixin or asm, which to me feels unnecessary when the change is so trivial on our end

[boubou19]

Can't twist update its code to use other constructors? GT5U is NH only, so if it has no use in NH...

It can't, the PR removing this constructor removed the only way for energy hatches to set their inventory size, and since it is passed up to set a final array (not wrapped with a getter), I'm not aware of any way to do this even with reflection since afaik on newer java VMs, using things to modify a final field with reflection doesn't work well. So the only option would be mixin or asm, which to me feels unnecessary when the change is so trivial on our end

It seems weird to me that we managed to remove the whole need for this constructor in NH but Twist can't... Anyways, explicit the comment about why and where it's needed, needed in an addon definitely will not age well. After this, let's merge it