Speedup Progress Bar #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se the rendering doesn't support some UNICODE. StripSpecialChars calls `CharMatcher.anyOf(ALLOWED_CHARS)` on every invocation, which does a bunch of allocations, sorting, etc. This wasn't a big deal on Vanilla, or other mods because they're not spamming thousands of materials on the progress bar. The obvious solution would be just... don't call this at all, and that might be safe for English Locales... but given strings sent to the progress bar might be localized, we instead backport the behavior from later forge versions which cache a static copy of `DISALLOWED_CHAR_MATCHER` and use that, instead of creating a new one on every function call.
glowredman
approved these changes
Dec 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every .step() function on ProgressBar calls
stripSpecialCharsbecause the rendering doesn't support some UNICODE.StripSpecialChars calls
CharMatcher.anyOf(ALLOWED_CHARS)on every invocation, which does a bunch of allocations, sorting, etc. This wasn't a big deal on Vanilla, or other mods because they're not spamming thousands of materials on the progress bar.The obvious solution would be just... don't call this at all, and that might be safe for English Locales... but given strings sent to the progress bar might be localized, we instead backport the behavior from later forge versions which cache a static copy of
DISALLOWED_CHAR_MATCHERand use that, instead of creating a new one on every function call.