Vanilla Crash & Furnace Speedup #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mitchej123
commented
Dec 11, 2021
mitchej123
commented
- Backports a fix for URL parsing from [1.7.10] internal server error on chat message MinecraftForge/MinecraftForge#1712
- Makes FurnaceRecipe significantly faster by using a HashMap w/ ItemStackHashingStrategy
1) Backports a fix for URL parsing from MinecraftForge/MinecraftForge#1712 2) Makes FurnaceRecipe significantly faster by using a HashMap w/ ItemStackHashingStrategy
3 tasks
repo-alt
reviewed
Dec 11, 2021
|
|
||
| @Override | ||
| public int computeHashCode(ItemStack stack) { | ||
| return stack.getItem().hashCode() ^ stack.getItemDamage() ^ (stack.hasTagCompound() ? stack.stackTagCompound.hashCode() : 0); |
There was a problem hiding this comment.
Wouldn't it give better distribution if you e.g. multiply item damage by some large enough prime here? It's not that expensive
Glease
reviewed
Dec 11, 2021
src/main/java/com/mitchej123/hodgepodge/asm/ThermosFurnaceSledgeHammer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mitchej123/hodgepodge/asm/ThermosFurnaceSledgeHammer.java
Show resolved
Hide resolved
* Going with the assumption GT registers things later and we want those. At first glance, most of the conflicts were dust -> ic2Ingot Update hashing strategy slightly
Dream-Master
approved these changes
Dec 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.