Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various getBlock fixes as pointed out by Boubou #6

Merged
merged 5 commits into from
Feb 7, 2021

Conversation

mitchej123
Copy link
Contributor

  • Switch grass fix to Redirect, merge with other vanilla fixes. Should now be Thermos compatible.
  • Various Vanilla getBlock fixes (Fire, Fluids, Villages)
  • Ic2 water kinetics getBlock fix
  • Thaumcraft getBlock Fixes (Arcane Lamp & Wisp)
  • Group block fixes

NOTE: Grass fix (fixGrassChunkLoads) is now fixVanillaUnprotectedGetBlock and no longer disables on thermos

 * Switch grass fix to Redirect, merge with other vanilla fixes.  Should now be Thermos compatible.
 * Various Vanilla getBlock fixes (Fire, Fluids, Villages)
 * Ic2 water kinetics getBlock fix
 * Thaumcraft getBlock Fixes (Arcane Lamp & Wisp)
 * Group block fixes

 NOTE: Grass fix (fixGrassChunkLoads) is now `fixVanillaUnprotectedGetBlock` and no longer disables on thermos
@mitchej123 mitchej123 requested a review from boubou19 February 7, 2021 02:17
@mitchej123
Copy link
Contributor Author

@boubou19 is testing on Zeta, and the other officials, will merge when we're happy it's fixed these/doesn't break

Copy link
Contributor

@repo-alt repo-alt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be probably mentioned in release notes that Water kinetics should be now chunkloaded along with their reservoir.

@Dream-Master Dream-Master merged commit f51e6ae into master Feb 7, 2021
@Dream-Master Dream-Master deleted the get_block_fixes branch February 7, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants