Remove the stickhelmet #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A tragic loss |
miozune
reviewed
Sep 29, 2024
| @@ -26,7 +25,6 @@ public StickItem() { | |||
| @SideOnly(Side.CLIENT) | |||
| @Override | |||
| public IIcon getIconFromDamage(int meta) { | |||
| if (meta >= textureNames.length) return Items.leather_helmet.getIconFromDamage(meta); | |||
There was a problem hiding this comment.
You can use Util.getWithFallback a716d2b (#16)
There was a problem hiding this comment.
I dont see why I would want to give textures to stuff that doesnt exist. most mods dont.
There was a problem hiding this comment.
there always is the default fallback: the flame. and it clearly tells you that something is broken and needs fixing.
There was a problem hiding this comment.
Well in the case I linked it crashed the game. As long as it doesn't, sure
miozune
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry for the nerf.
these stickhelmets:
