Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make advanced provider can bind to multi matrix #77

Merged
merged 4 commits into from
Oct 13, 2024

Conversation

MCTBL
Copy link
Member

@MCTBL MCTBL commented Sep 22, 2024

image

now advanced infusion provider can bind to multiple matrix in 25 X 25 X 11 area

because the matrix will detect pedestal in 17 X 17 area, so maybe 4 matrix is the upper limit

and now it can request 16 crafting job max, before is only 1 job a time

testOut.mp4

and can request 16 crafting job max
@MCTBL MCTBL changed the title make advanced provider can bind to mutil matrix make advanced provider can bind to multi matrix Sep 22, 2024
@MCTBL MCTBL requested a review from a team September 22, 2024 13:17
@MCTBL
Copy link
Member Author

MCTBL commented Sep 22, 2024

image

Copy link

@Alastors Alastors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, I think this is a bit OP, and not necessary

@Dream-Master
Copy link
Member

Nah, I think this is a bit OP, and not necessary

If it is op we can look for a better recipe ? The recipe looks quite cheap @MCTBL

@Alastors
Copy link

Alastors commented Sep 22, 2024

Nah, I think this is a bit OP, and not necessary

If it is op we can look for a better recipe ? The recipe looks quite cheap @MCTBL

Nah, it just doesn't need to happen, there's nothing wrong with "1 Provider per matrix", it's effectively an essentia hatch, this is effectively like wall sharing hatches. I.e. it shouldn't be how it works

Mind you dream, this is already in pack, not the "more than one matrix" thing, the advanced provider itself

@Dream-Master
Copy link
Member

@Alastors It's good that we always agree :trollface:

Copy link

@OneEyeMaker OneEyeMaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that with such update this device becomes really Advanced Infusion Provider. And I don't think it's too OP: it just needs to be properly tiered.

@Dream-Master Don't worry about recipes here. These recipes are vanilla-like. The real ones will go to NHCore.

@Alastors
Copy link

Even the GTNH version of this recipe is insanely too cheap, it needs to be at least LuV or ZPM+

@Dream-Master
Copy link
Member

Even the GTNH version of this recipe is insanely too cheap, it needs to be at least LuV or ZPM+

Let’s nerf it .

@EnderProyects
Copy link

Even the GTNH version of this recipe is insanely too cheap, it needs to be at least LuV or ZPM+

You say that but yours intercepter is one of the cheapests infusions in the pack lmao

@Alastors
Copy link

Alastors commented Sep 23, 2024

Even the GTNH version of this recipe is insanely too cheap, it needs to be at least LuV or ZPM+

You say that but yours intercepter is one of the cheapests infusions in the pack lmao

The intercepter is literally a performance boosting item that requires EV tier stuff to use, this isn't.

My intercepter requires 1 essentia provider per matrix, this is an all in one that does as many matrix as you can fit into the area all at once (16 or so)

If this is "meant to be an upgrade" then it shouldn't be in the same tier as the things it's "upgrading" and since it replaces up to 16 all at once, it should be multiple tiers higher

@EnderProyects
Copy link

I dont see any part of the intercepter that needs EV
image
Also the GTNH recipe is a bit more costly
image

@Alastors Alastors added ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version affects balance Requires admin approval before merging labels Sep 23, 2024
@Alastors
Copy link

Alastors commented Sep 23, 2024

I dont see any part of the intercepter that needs EV

image

Also the GTNH recipe is a bit more costly

image

Ender, for Christ's sake, try piping essentia into it and you'll see it requires the essentia provider. 🤦‍♂️

His doesn't require an essntia provider and does 16 matrix at once at the same tier if this were accepted without a necessary nerf

@EnderProyects
Copy link

It uses one infusion provider...
image

@Alastors
Copy link

It uses one infusion provider...

image

And replaces 16 at the same tier 🤦‍♂️

@Dream-Master
Copy link
Member

@Alastors what else need to be changed ?

@Alastors
Copy link

Alastors commented Sep 30, 2024

@Alastors what else need to be changed ?

We need a recipe tier up proposal at the very least, at least LuV-ZPM

@Alastors
Copy link

Alastors commented Sep 30, 2024

Also we're in a feature freeze this is not a good moment to test new content

@Dream-Master
Copy link
Member

@Alastors what else need to be changed ?

We need a recipe tier up proposal at the very least, at least LuV-ZPM

@MCTBL any recipe idea Luv based ?

@Dream-Master
Copy link
Member

Also we're in a feature freeze this is not a good moment to test new content

Yes but we can make the pr ready for after stable

@MCTBL
Copy link
Member Author

MCTBL commented Sep 30, 2024

like add some Primordial Pearl for NH's price? will that need change in NH core mod.

@Dream-Master
Copy link
Member

like add some Primordial Pearl for NH's price? will that need change in NH core mod.

yes recipes for nh in core mod please. About ingrrediens we need to ask Magic Master @Alastors 😆

@Alastors
Copy link

like add some Primordial Pearl for NH's price? will that need change in NH core mod.

yes recipes for nh in core mod please. About ingrrediens we need to ask Magic Master @Alastors 😆

No magic ingredients will help this be higher tier, you can get primordial pearls as early as HV, but sure you can throw in primordial pearls, you should also throw in maybe the Master or Grandmaster diffusion cells, since those are the closest we have to magic tiering stuff

@MCTBL
Copy link
Member Author

MCTBL commented Oct 4, 2024

like add some Primordial Pearl for NH's price? will that need change in NH core mod.

yes recipes for nh in core mod please. About ingrrediens we need to ask Magic Master @Alastors 😆

No magic ingredients will help this be higher tier, you can get primordial pearls as early as HV, but sure you can throw in primordial pearls, you should also throw in maybe the Master or Grandmaster diffusion cells, since those are the closest we have to magic tiering stuff

Luv can unlock all diffusion cells, but there has not that much recipces after Luv

@Alastors
Copy link

Alastors commented Oct 4, 2024

like add some Primordial Pearl for NH's price? will that need change in NH core mod.

yes recipes for nh in core mod please. About ingrrediens we need to ask Magic Master @Alastors 😆

No magic ingredients will help this be higher tier, you can get primordial pearls as early as HV, but sure you can throw in primordial pearls, you should also throw in maybe the Master or Grandmaster diffusion cells, since those are the closest we have to magic tiering stuff

Luv can unlock all diffusion cells, but there has not that much recipces after Luv

So add non-magic materials, but the highest cell should be ZPM

@MCTBL
Copy link
Member Author

MCTBL commented Oct 5, 2024

like add some Primordial Pearl for NH's price? will that need change in NH core mod.

yes recipes for nh in core mod please. About ingrrediens we need to ask Magic Master @Alastors 😆

No magic ingredients will help this be higher tier, you can get primordial pearls as early as HV, but sure you can throw in primordial pearls, you should also throw in maybe the Master or Grandmaster diffusion cells, since those are the closest we have to magic tiering stuff

Luv can unlock all diffusion cells, but there has not that much recipces after Luv

So add non-magic materials, but the highest cell should be ZPM

image
use ZPM sensor and emitter, is this enough?

@Alastors
Copy link

Alastors commented Oct 5, 2024

like add some Primordial Pearl for NH's price? will that need change in NH core mod.

yes recipes for nh in core mod please. About ingrrediens we need to ask Magic Master @Alastors 😆

No magic ingredients will help this be higher tier, you can get primordial pearls as early as HV, but sure you can throw in primordial pearls, you should also throw in maybe the Master or Grandmaster diffusion cells, since those are the closest we have to magic tiering stuff

Luv can unlock all diffusion cells, but there has not that much recipces after Luv

So add non-magic materials, but the highest cell should be ZPM

image

use ZPM sensor and emitter, is this enough?

What's the earliest you can access them, not currently in game

@EnderProyects
Copy link

Instead of primal charms could you make that it uses strange crystals? 👉👈 ( it needs eldritch researchs)

@Miklebe
Copy link

Miklebe commented Oct 5, 2024

What's the earliest you can access them, not currently in game

Since ZPM stuff needs europium, and a decent chunk of it, the earliest is LuV cus of MK1 fusion/tier 5 (zpm assembly rocket)

@Alastors
Copy link

Alastors commented Oct 5, 2024

What's the earliest you can access them, not currently in game

Since ZPM stuff needs europium, and a decent chunk of it, the earliest is LuV cus of MK1 fusion/tier 5 (zpm assembly rocket)

That's probably fine then

@Dream-Master Dream-Master requested review from OneEyeMaker and a team October 5, 2024 10:20
@Dream-Master Dream-Master merged commit 501e024 into GTNewHorizons:master Oct 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects balance Requires admin approval before merging ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants