[fix](window function) Fix illegal frame range

Gabriel39 · Sep 23, 2024 · a518503 · a518503
1 parent f57dc92
commit a518503
Show file tree

Hide file tree

Showing 4 changed files with 247 additions and 4 deletions.
diff --git a/be/src/pipeline/exec/analytic_source_operator.cpp b/be/src/pipeline/exec/analytic_source_operator.cpp
@@ -355,14 +355,16 @@ Status AnalyticLocalState::_get_next_for_rows(size_t current_block_rows) {
  1; //going on calculate,add up data, no need to reset state
  } else {
  _reset_agg_status();
+ range_end = _shared_state->current_row_position + _rows_end_offset + 1;
  if (!_parent->cast<AnalyticSourceOperatorX>()
  ._window.__isset
  .window_start) { //[preceding, offset] --unbound: [preceding, following]
  range_start = _partition_by_start.pos;
  } else {
  range_start = _shared_state->current_row_position + _rows_start_offset;
  }
- range_end = _shared_state->current_row_position + _rows_end_offset + 1;
+ // Make sure range_start <= range_end
+ range_start = std::min(range_start, range_end);
  }
  _executor.execute(_partition_by_start.pos, _shared_state->partition_by_end.pos, range_start,
  range_end);

diff --git a/be/src/vec/aggregate_functions/aggregate_function_window.h b/be/src/vec/aggregate_functions/aggregate_function_window.h
@@ -499,9 +499,9 @@ template <typename Data, bool arg_ignore_null = false>
 struct WindowFunctionLastImpl : Data {
  void add_range_single_place(int64_t partition_start, int64_t partition_end, int64_t frame_start,
  int64_t frame_end, const IColumn** columns) {
- if ((frame_start <= frame_end) &&
-   ((frame_end <= partition_start) ||
-  (frame_start >= partition_end))) { //beyond or under partition, set null
+ DCHECK_LE(frame_start, frame_end);
+ if ((frame_end <= partition_start) ||
+ (frame_start >= partition_end)) { //beyond or under partition, set null
  this->set_is_null();
  return;
  }

diff --git a/regression-test/data/nereids_syntax_p0/window_function.out b/regression-test/data/nereids_syntax_p0/window_function.out
@@ -359,3 +359,205 @@
 1.0
 1.5
 
+-- !sql --
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+
diff --git a/regression-test/suites/nereids_syntax_p0/window_function.groovy b/regression-test/suites/nereids_syntax_p0/window_function.groovy