Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node.js 12 actions are deprecated. #30

Closed
unional opened this issue Oct 14, 2022 · 8 comments
Closed

Node.js 12 actions are deprecated. #30

unional opened this issue Oct 14, 2022 · 8 comments

Comments

@unional
Copy link

unional commented Oct 14, 2022

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: GabrielBB/xvfb-action
This was referenced Oct 14, 2022
Closed
Closed
@alisonatwork alisonatwork mentioned this issue Oct 30, 2022
Merged
@maximilianpilz maximilianpilz mentioned this issue Nov 2, 2022
Open
@tlambert03
Copy link

hey @GabrielBB ... Just checking in. Are you still maintaining this? or should we look into a fork for node16?

@alisonatwork
Copy link

After a couple months of no feedback on this ticket, I tried to find another way to fix this, and the good news is that the ubuntu-latest image now includes xvfb-run so there is no need to overlay this image any more.

See this PR for how I fixed it for the amVim VS Code extension: aioutecism/amVim-for-VSCode#315

booo added a commit to booo/qgroundcontrol that referenced this issue Dec 4, 2022
@booo
Github actions: Fix deprecation warning for node12
647936a 
"Node.js 12 actions are deprecated. For more information see:

https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

Please update the following actions to use Node.js 16:

GabrielBB/xvfb-action@v1"

Replaces the obsolete action as suggested by @alisonatwork in

GabrielBB/xvfb-action#30 (comment)
This was referenced Dec 4, 2022
Closed
Merged
patrickelectric pushed a commit to mavlink/qgroundcontrol that referenced this issue Dec 4, 2022
@booo @patrickelectric
Github actions: Fix deprecation warning for node12
8e11aa3 
"Node.js 12 actions are deprecated. For more information see:

https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

Please update the following actions to use Node.js 16:

GabrielBB/xvfb-action@v1"

Replaces the obsolete action as suggested by @alisonatwork in

GabrielBB/xvfb-action#30 (comment)
@JanWittler JanWittler mentioned this issue Dec 13, 2022
Closed
hyangah added a commit to hyangah/vscode-go that referenced this issue Dec 29, 2022
@hyangah
.github/workflows: replace xvfb-action with xvfb-run
27e4ea7 
ubuntu-latest image includes xvfb-run according to
GabrielBB/xvfb-action#30 (comment)
so we do not need to depend on this xvfb-action.

This also fixes the deprecation warning about outdated node
version.

Change-Id: I142da13af09be9583850be3322c0b358e3e094ad
hyangah added a commit to hyangah/vscode-go that referenced this issue Dec 29, 2022
@hyangah
.github/workflows: replace xvfb-action with xvfb-run
95be427 
FORCE RUN CI

ubuntu-latest image includes xvfb-run according to
GabrielBB/xvfb-action#30 (comment)
so we do not need to depend on this xvfb-action.

This also fixes the deprecation warning about outdated node
version.

Change-Id: I142da13af09be9583850be3322c0b358e3e094ad
hyangah added a commit to hyangah/vscode-go that referenced this issue Dec 29, 2022
@hyangah
.github/workflows: replace xvfb-action with xvfb-run
c54aee5 
FORCE RUN CI

ubuntu-latest image includes xvfb-run according to
GabrielBB/xvfb-action#30 (comment)
so we do not need to depend on this xvfb-action.

This also fixes the deprecation warning about outdated node
version.

Change-Id: I142da13af09be9583850be3322c0b358e3e094ad
pantajoe added a commit to pantajoe/vscode-elixir-credo that referenced this issue Dec 29, 2022
@pantajoe
ci: replace xvfb-action with native xvfb-run
aa273fd 
see GabrielBB/xvfb-action#30
@pantajoe pantajoe mentioned this issue Dec 29, 2022
Merged
pantajoe added a commit to pantajoe/vscode-elixir-credo that referenced this issue Dec 29, 2022
@pantajoe
ci: replace xvfb-action with native xvfb-run (#302)
1eda723 
see GabrielBB/xvfb-action#30
@ssbarnea
Copy link

ssbarnea commented Dec 30, 2022 •
edited
Loading

As the maintenance status of this extension is under question, you might want to switch to https://github.com/coactions/setup-xvfb (fork) which already sorted this issue.

gopherbot pushed a commit to golang/vscode-go that referenced this issue Jan 4, 2023
@hyangah
.github/workflows: replace xvfb-action with xvfb-run
5ec591d 
ubuntu-latest image includes xvfb-run according to
GabrielBB/xvfb-action#30 (comment)
so we do not need to depend on this xvfb-action.

This also fixes the deprecation warning about outdated node
version.

Change-Id: I142da13af09be9583850be3322c0b358e3e094ad
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/459861
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
lunkwill42 added a commit to Uninett/nav that referenced this issue Jan 4, 2023
@lunkwill42
Replace GabrielBB/xvfb-action with native solution
ec12168 
xvfb-run is now supported by the 'ubuntu-latest' runner, while
GabrielBB/xvfb-action is causing deprecation warnings about Node.js 12.
See GabrielBB/xvfb-action#30
@Czaki Czaki mentioned this issue Jan 13, 2023
Closed
o01eg added a commit to o01eg/freeorion that referenced this issue Jan 21, 2023
@o01eg
Update xvfb Github Action from deprecated Node.js 12
80c3f5e 
See GabrielBB/xvfb-action#30 (comment)
@o01eg o01eg mentioned this issue Jan 21, 2023
Merged
@SuperSodaSea SuperSodaSea mentioned this issue Jan 23, 2023
Merged
@cdietrich cdietrich mentioned this issue Jan 26, 2023
Closed
@Mailaender Mailaender mentioned this issue Jan 28, 2023
Merged
o01eg added a commit to freeorion/freeorion that referenced this issue Jan 30, 2023
@o01eg
Update xvfb Github Action from deprecated Node.js 12
17e1b3d 
See GabrielBB/xvfb-action#30 (comment)
Vezzra pushed a commit to freeorion/freeorion that referenced this issue Jan 30, 2023
@o01eg @Vezzra
Update xvfb Github Action from deprecated Node.js 12
64ef810 
See GabrielBB/xvfb-action#30 (comment)

(cherry picked from commit 17e1b3d)
amclin added a commit to amclin/videojs-scene7 that referenced this issue Feb 10, 2023
@amclin
ci: bump replace xvfb setup with one providing newer Node support
4de9b97 
Node 12 is deprecated on github actions
the xvfb action is not being maintained
See GabrielBB/xvfb-action#30
@ElianHugh ElianHugh mentioned this issue Feb 14, 2023
Open
@dlopezalvas dlopezalvas mentioned this issue Mar 20, 2023
Merged
@laeubi
Copy link

laeubi commented Mar 21, 2023

Any update on this?

@ssbarnea
Copy link

@laeubi That is why I forked it under https://github.com/coactions/setup-xvfb so we can continue maintaining it as a community. GH is full of orphan projects and most of them are under personal accounts.

@GabrielBB
Copy link
Owner

Thank you so much @ssbarnea . I updated my README to notify deprecation and link to the new repo. I'll be closing this issue as the new repo solves it already

@ssbarnea
Copy link

@GabrielBB Thanks. If you want I am more than happy to also invite you as a maintainer to the repo. My hopes was to promote the coactions to others, so we can lower the maintenance burden but I never had time to do PR for that.

@GabrielBB
Copy link
Owner

GabrielBB commented Mar 21, 2023 •
edited
Loading

@ssbarnea Okay, you can invite me. Do you know why the "contributors" section is not showing there? like it's shown here:

image

shift-tyson pushed a commit to Shift-Environmental/shift-qgc that referenced this issue May 17, 2024
@booo @patrickelectric
Github actions: Fix deprecation warning for node12
c1c1f54 
"Node.js 12 actions are deprecated. For more information see:

https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

Please update the following actions to use Node.js 16:

GabrielBB/xvfb-action@v1"

Replaces the obsolete action as suggested by @alisonatwork in

GabrielBB/xvfb-action#30 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ssbarnea @alisonatwork @laeubi @tlambert03 @unional @GabrielBB