use EnumSet in MachineBlockEntity for valid connection directions #483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
MachineBlockEntity#validConnections
uses anArrayList
for storing connection directions, this is significantly slower than usingEnumSet
, forcontains
operations. this performance difference manifests when large networks transfer energy. No accesses of this value rely on order of elements, so changing the collection implementation used produces no differences in behavior.