-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: minor information improvements #7
Conversation
@@ -85,6 +88,11 @@ The main disadvantage of using Nix are: | |||
Nix is an untyped language with no special Haskell integration, so error | |||
messages are unhelpful | |||
|
|||
* No incremental compilation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By no incremental compilation, do you mean that Nix builds the Haskell project from scratch each time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then maybe expand this to:
Nix cannot incrementally compile Haskell libraries
Note that you can still use Nix to provision a development environment and incrementally compile a Haskell package using
cabal
. However, if you use Nix to build the package then Nix will build the package from scratch for every minor change. In theory, this could be fixed to have Nix directly support incremental Haskell builds but this has not been done yet.
|
||
* No Windows support | ||
|
||
Nix does not appear to work at all on Windows | ||
|
||
* Poor OS X support for stable releases | ||
[There is hope for Windows 10](https://github.com/NixOS/nix/issues/1038) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From reading the linked issue, does the newly added native Bash support on Windows fix the remaining problems with getting Windows working or are there still other remaining issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bash support mostly means POSIX, so even if there are some further issues I'm confident Nix can be supported on Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you then combine these two sentences to:
- No Windows support
Nix does not yet work on Windows but there is a very good chance that Nix can be ported to Windows soon
|
||
* No Windows support | ||
|
||
Nix does not appear to work at all on Windows | ||
|
||
* Poor OS X support for stable releases | ||
[There is hope for Windows 10](https://github.com/NixOS/nix/issues/1038) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you then combine these two sentences to:
- No Windows support
Nix does not yet work on Windows but there is a very good chance that Nix can be ported to Windows soon
@@ -85,6 +88,11 @@ The main disadvantage of using Nix are: | |||
Nix is an untyped language with no special Haskell integration, so error | |||
messages are unhelpful | |||
|
|||
* No incremental compilation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then maybe expand this to:
Nix cannot incrementally compile Haskell libraries
Note that you can still use Nix to provision a development environment and incrementally compile a Haskell package using
cabal
. However, if you use Nix to build the package then Nix will build the package from scratch for every minor change. In theory, this could be fixed to have Nix directly support incremental Haskell builds but this has not been done yet.
Let me know what you think about these @Gabriel439
Most of the disadvantages have "it depends", but I'm not sure if you think that's relevant for the tutorial. I think it's worth mentioning where to track the issue.