Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only import torch.distributed if it is available #1

Closed
wants to merge 1 commit into from

Conversation

GaetanLepage
Copy link
Owner

What does this PR do?

torch.distributed is sometimes unavailable (on some platforms such as darwin).
It leads to transformers.models.auto.modeling_auto to fail to import with:

ModuleNotFoundError: No module named 'torch._C._distributed_c10d'; 'torch._C' is not a package

I propose to implement a similar logic as in huggingface/accelerate#2121 to load torch.distributed conditionally on its availability.
I was able to test the patch in nixpkgs successfully.

Fixes huggingface#35129

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No module named 'torch._C._distributed_c10d'; 'torch._C' is not a package on darwin
1 participant