HiddenFilePathFilter: Fix hidden sequences #5831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhaddon
reviewed
Apr 30, 2024
Changes.md
Outdated
| Fixes | ||
| ----- | ||
|
|
||
| - File Browser : Windows only : Fixed bug in `HiddenFilePathFilter` that caused sequences to be treated as though they are hidden files. |
There was a problem hiding this comment.
We should reference the relevant issue here with #.
There was a problem hiding this comment.
Right, thanks for the reminder. Added and squashed into 6108cc8
Fixes GafferHQ#5810 When checking a path that has the `#` character for frame substitutions, `HiddenFilePathFilter` would always treat it as hidden. The file with `#` does not exist, so the Windows API would return `INVALID_FILE_ATTRIBUTES` whose value is `-1`. `FILE_ATTRIBUTE_HIDDEN` has a value of `2`. `-1 & 2 = 2`, so sequences would always be considered hidden.
ericmehl
force-pushed
the
fixHiddenSequences
branch
from
f12e841 to
6108cc8
Compare
|
I was getting away with not sorting the file lists in the unit test on Windows, but Linux was not as forgiving. Should be sorted literally and figuratively in 6108cc8. |
johnhaddon
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5810
When checking a path that has the
#character for frame substitutions,HiddenFilePathFilterwould always treat it as hidden. The file with#does not exist, so the Windows API would returnINVALID_FILE_ATTRIBUTESwhose value is-1.FILE_ATTRIBUTE_HIDDENhas a value of2.-1 & 2 = 2, so sequences would always be considered hidden.Checklist